Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62731
Change subject: Bug fix for 41619
......................................................................
Bug fix for 41619
Converting hard coded strings to i18n values
Change-Id: Ib9b80518433fae24282f3006c00bed257291a47e
---
M lib/WikibaseLib.i18n.php
M lib/includes/EntityDiffVisualizer.php
2 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/31/62731/1
diff --git a/lib/WikibaseLib.i18n.php b/lib/WikibaseLib.i18n.php
index 060d1d5..c583d34 100644
--- a/lib/WikibaseLib.i18n.php
+++ b/lib/WikibaseLib.i18n.php
@@ -1,4 +1,4 @@
-<?php
+<?php
/**
* Internationalization file for the WikibaseLib extension.
@@ -24,6 +24,10 @@
'wikibase-diffview-reference' => 'reference',
'wikibase-diffview-rank' => 'rank',
'wikibase-diffview-qualifier' => 'qualifier',
+ 'wikibase-diffview-label' => 'label',
+ 'wikibase-diffview-alias' => 'aliases',
+ 'wikibase-diffview-description' => 'description',
+ 'wikibase-diffview-link' => 'links',
'wikibase-error-unexpected' => 'An unexpected error occurred.',
'wikibase-error-save-generic' => 'An error occurred while trying to
perform save and because of this, your changes could not be completed.',
'wikibase-error-remove-generic' => 'An error occurred while trying to
perform remove and because of this, your changes could not be completed.',
diff --git a/lib/includes/EntityDiffVisualizer.php
b/lib/includes/EntityDiffVisualizer.php
index dcf6538..3ac84bc 100644
--- a/lib/includes/EntityDiffVisualizer.php
+++ b/lib/includes/EntityDiffVisualizer.php
@@ -92,9 +92,9 @@
$termDiffVisualizer = new DiffView(
array(),
new Diff( array(
- 'label' => $diff->getLabelsDiff(),
- 'aliases' => $diff->getAliasesDiff(),
- 'description' => $diff->getDescriptionsDiff(),
+ wfMessage( 'wikibase-diffview-label')->plain()
=> $diff->getLabelsDiff(),
+ wfMessage( 'wikibase-diffview-alias')->plain()
=> $diff->getAliasesDiff(),
+ wfMessage(
'wikibase-diffview-description')->plain() => $diff->getDescriptionsDiff(),
), true ),
$this->context
);
@@ -110,7 +110,7 @@
$termDiffVisualizer = new DiffView(
array(),
new Diff( array(
- 'links' => $diff->getSiteLinkDiff(),
+ wfMessage(
'wikibase-diffview-link')->plain() => $diff->getSiteLinkDiff(),
), true ),
$this->context
);
--
To view, visit https://gerrit.wikimedia.org/r/62731
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9b80518433fae24282f3006c00bed257291a47e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
