Mwalker has submitted this change and it was merged.
Change subject: Save banner messages even if the name contains a hyphen
......................................................................
Save banner messages even if the name contains a hyphen
Change-Id: I5be095f40ae85c79c246de28aafe590bb7221463
---
M special/SpecialCentralNoticeBanners.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Mwalker: Verified; Looks good to me, approved
diff --git a/special/SpecialCentralNoticeBanners.php
b/special/SpecialCentralNoticeBanners.php
index 3fe8a17..b8624c0 100644
--- a/special/SpecialCentralNoticeBanners.php
+++ b/special/SpecialCentralNoticeBanners.php
@@ -710,9 +710,9 @@
// But only if we aren't using translate or if the preview
language is the content language
if ( !$wgNoticeUseTranslateExtension || (
$this->bannerLanguagePreview === $wgLanguageCode ) ) {
foreach( $formData as $key => $value ) {
- $parts = explode( '-', $key );
- if ( ( count( $parts ) === 2 ) && ( $parts[0]
=== 'message' ) ) {
- $bannerMessage =
$banner->getMessageField( $parts[1] );
+ if ( strpos( $key, 'message-' ) === 0 ) {
+ $messageName = substr( $key, strlen(
'message-' ) );
+ $bannerMessage =
$banner->getMessageField( $messageName );
$bannerMessage->update( $value,
$this->bannerLanguagePreview, $this->getUser() );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/62733
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5be095f40ae85c79c246de28aafe590bb7221463
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Adamw <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
