jenkins-bot has submitted this change and it was merged.
Change subject: Add .jshintrc and fix warnings
......................................................................
Add .jshintrc and fix warnings
Copied from Translate
Change-Id: I3999eb2f87d006c469b745c4c6dc58ab4eb35eba
---
A .jshintrc
M resources/js/ext.translate.mainpage.js
2 files changed, 43 insertions(+), 3 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jshintrc b/.jshintrc
new file mode 100644
index 0000000..b6a0f58
--- /dev/null
+++ b/.jshintrc
@@ -0,0 +1,40 @@
+{
+ /* Common */
+
+ // Enforcing
+ "camelcase": true,
+ "curly": true,
+ "eqeqeq": true,
+ "immed": true,
+ "latedef": true,
+ "newcap": true,
+ "noarg": true,
+ "noempty": true,
+ "nonew": true,
+ "quotmark": "single",
+ "trailing": true,
+ "undef": true,
+ "unused": true,
+ // Legacy
+ "onevar": true,
+
+ /* Local */
+
+ // Enforcing
+ "bitwise": true,
+ "forin": false,
+ "regexp": false,
+ "strict": true,
+ // Relaxing
+ "laxbreak": true,
+ "smarttabs": true,
+ "multistr": true,
+ // Environment
+ "browser": true,
+
+ "predef": [
+ "mediaWiki",
+ "jQuery",
+ "QUnit"
+ ]
+}
diff --git a/resources/js/ext.translate.mainpage.js
b/resources/js/ext.translate.mainpage.js
index 3f1de64..be43b63 100644
--- a/resources/js/ext.translate.mainpage.js
+++ b/resources/js/ext.translate.mainpage.js
@@ -68,7 +68,7 @@
username: username,
email: email,
password: password,
- token: $form.find(
'input[name="wpSandboxToken"]' ).val(),
+ token: $form.find(
'input[name="wpSandboxToken"]' ).val()
};
req = api.post( options );
@@ -81,10 +81,10 @@
action: 'login',
lgname: username,
lgpassword: password
- }
+ };
req = api.post( options );
- req.fail( function () { window.alert(
'Failure2' ); } )
+ req.fail( function () { window.alert(
'Failure2' ); } );
req.done( function ( data ) {
var req,
api = new mw.Api();
--
To view, visit https://gerrit.wikimedia.org/r/62790
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3999eb2f87d006c469b745c4c6dc58ab4eb35eba
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TwnMainPage
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
