jenkins-bot has submitted this change and it was merged.
Change subject: Position the "Refresh" link over the image
......................................................................
Position the "Refresh" link over the image
This changes the CSS of the .fancycaptcha-image-container to allow
positioning within it, and repositions .fancycaptcha-reload at its
lower-right. The container is taller than nearly all images, but
there's a chance the ↻Refresh link might obscure part of a captcha
image.
This is compatible with the new Create account form's repositioning of
the FancyCaptcha inside a gray frame using JS, though gerrit I003c5f1b75
improves Create account once this is deployed.
Bug: 47699
Change-Id: I57be0bc8aa80b9ea6148db979ad28397d2107b86
---
M FancyCaptcha.class.php
M resources/ext.confirmEdit.fancyCaptcha.css
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/FancyCaptcha.class.php b/FancyCaptcha.class.php
index 128dacf..7ea9933 100644
--- a/FancyCaptcha.class.php
+++ b/FancyCaptcha.class.php
@@ -119,6 +119,7 @@
'alt' => ''
)
) .
+ $captchaReload .
"</div>\n" .
'<p>' .
Html::element( 'label', array(
@@ -137,7 +138,6 @@
'tabindex' => 1
)
) . // tab in before the edit textarea
- $captchaReload .
Html::element( 'input', array(
'type' => 'hidden',
'name' => 'wpCaptchaId',
diff --git a/resources/ext.confirmEdit.fancyCaptcha.css
b/resources/ext.confirmEdit.fancyCaptcha.css
index 738cf90..96e4dd6 100644
--- a/resources/ext.confirmEdit.fancyCaptcha.css
+++ b/resources/ext.confirmEdit.fancyCaptcha.css
@@ -7,6 +7,8 @@
layout, for normal CAPTCHA sizes. */
.fancycaptcha-image-container {
min-height: 95px;
+ position: relative; /* to position Reload link within this */
+ display: inline-block;
}
.client-nojs .fancycaptcha-reload {
@@ -31,3 +33,9 @@
/* @embed */
background: url(images/ajax-loader-10x10.gif) no-repeat scroll left
center transparent;
}
+
+.fancycaptcha-image-container .fancycaptcha-reload {
+ position: absolute;
+ bottom: 0;
+ right: 4px;
+}
--
To view, visit https://gerrit.wikimedia.org/r/62191
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57be0bc8aa80b9ea6148db979ad28397d2107b86
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ConfirmEdit
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: Swalling <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
