Milimetric has submitted this change and it was merged. Change subject: Bug fix for 'Group parameter not honored', Mingle #603 ......................................................................
Bug fix for 'Group parameter not honored', Mingle #603 Check https://github.com/wikimedia/analytics-user-metrics/search?q=REQUEST_VALUE_MAPPING&source=c for why I think this could solve the bug. Change-Id: I338692301f420baf34ea112e8b6d6a28cc8d9f85 --- M user_metrics/api/engine/request_meta.py 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Milimetric: Verified; Looks good to me, approved diff --git a/user_metrics/api/engine/request_meta.py b/user_metrics/api/engine/request_meta.py index bbcb54c..dac1712 100644 --- a/user_metrics/api/engine/request_meta.py +++ b/user_metrics/api/engine/request_meta.py @@ -55,10 +55,8 @@ # Default group + structure that maps values in the query string to new ones DEFAULT_GROUP = 'reg' REQUEST_VALUE_MAPPING = { - 'group': { 'reg': USER_METRIC_PERIOD_TYPE.REGISTRATION, 'activity': USER_METRIC_PERIOD_TYPE.INPUT, - } } def RequestMetaFactory(cohort_expr, cohort_gen_timestamp, metric_expr): -- To view, visit https://gerrit.wikimedia.org/r/62974 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I338692301f420baf34ea112e8b6d6a28cc8d9f85 Gerrit-PatchSet: 2 Gerrit-Project: analytics/user-metrics Gerrit-Branch: master Gerrit-Owner: Diederik <[email protected]> Gerrit-Reviewer: Milimetric <[email protected]> Gerrit-Reviewer: Rfaulk <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
