Mwalker has uploaded a new change for review.
https://gerrit.wikimedia.org/r/62987
Change subject: Use .change() instead of .click() in UI elements
......................................................................
Use .change() instead of .click() in UI elements
$.change() is more appropriate for HTML UI elements. $.click() was
apparently causing premature callbacks.
Change-Id: I045f85a1cb7768cdd9d973b6be4f0f4e5ea2c400
---
M modules/ext.centralNotice.adminUi.bannerEditor/bannereditor.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/87/62987/1
diff --git a/modules/ext.centralNotice.adminUi.bannerEditor/bannereditor.js
b/modules/ext.centralNotice.adminUi.bannerEditor/bannereditor.js
index 152cec2..15bc052 100644
--- a/modules/ext.centralNotice.adminUi.bannerEditor/bannereditor.js
+++ b/modules/ext.centralNotice.adminUi.bannerEditor/bannereditor.js
@@ -171,8 +171,8 @@
$( '#mw-input-wpdelete-button' ).click(
mw.centralNotice.adminUi.bannerEditor.doDeleteBanner );
$( '#mw-input-wparchive-button' ).click(
mw.centralNotice.adminUi.bannerEditor.doArchiveBanner );
$( '#mw-input-wpclone-button' ).click(
mw.centralNotice.adminUi.bannerEditor.doCloneBannerDialog );
- $( '#mw-input-wptranslate-language' ).click(
mw.centralNotice.adminUi.bannerEditor.updateLanguage );
- $( '#mw-input-wpcreate-landingpage-link' ).click(
mw.centralNotice.adminUi.bannerEditor.showHideLpEditBox );
+ $( '#mw-input-wptranslate-language' ).change(
mw.centralNotice.adminUi.bannerEditor.updateLanguage );
+ $( '#mw-input-wpcreate-landingpage-link' ).change(
mw.centralNotice.adminUi.bannerEditor.showHideLpEditBox );
// And do some initial form work
mw.centralNotice.adminUi.bannerEditor.showHideLpEditBox();
--
To view, visit https://gerrit.wikimedia.org/r/62987
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I045f85a1cb7768cdd9d973b6be4f0f4e5ea2c400
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
