Adamw has submitted this change and it was merged.
Change subject: Previews now work in all languages
......................................................................
Previews now work in all languages
Fixing a bug which caused the 'preview all languages' link to only
display in english.
Side note... we really need to unify the banner contexts.
Change-Id: I8c7beff27e89e26e6a7420567e1ccb5eff02859d
---
M special/SpecialCentralNoticeBanners.php
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Adamw: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/special/SpecialCentralNoticeBanners.php
b/special/SpecialCentralNoticeBanners.php
index b8624c0..2764f95 100644
--- a/special/SpecialCentralNoticeBanners.php
+++ b/special/SpecialCentralNoticeBanners.php
@@ -343,7 +343,7 @@
'section' => 'preview',
'class' => 'HTMLCentralNoticeBanner',
'banner' => $this->bannerName,
- 'language' => $this->getLanguage()->getCode(),
+ 'language' => $this->bannerLanguagePreview,
);
/* --- Banner Settings --- */
@@ -489,7 +489,7 @@
'class' => 'HTMLInfoField',
'disabled' => !$this->editable,
'label-raw' => Linker::link(
- $this->getTitle(
"Preview/{$this->bannerName}" ),
+ $this->getTitle(
"preview/{$this->bannerName}" ),
$this->msg(
'centralnotice-preview-all-template-translations' )->escaped()
),
'default' => implode( ', ',
$liveMessageNames ),
@@ -768,10 +768,13 @@
$htmlOut = '';
$langContext = new DerivativeContext( $this->getContext() );
- $bannerRenderer = new BannerRenderer( $langContext, $banner );
foreach ( $langs as $lang ) {
+ // HACK: We need to unify these two contexts...
$langContext->setLanguage( $lang );
+ $allocContext = new AllocationContext( 'XX', $lang,
'wikipedia', true, 'desktop', 0 );
+ $bannerRenderer = new BannerRenderer( $langContext,
$banner, 'test', $allocContext );
+
// Link and Preview all available translations
$htmlOut .= Xml::tags(
'td',
--
To view, visit https://gerrit.wikimedia.org/r/62997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c7beff27e89e26e6a7420567e1ccb5eff02859d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
