jenkins-bot has submitted this change and it was merged.

Change subject: Reduction of renderContents calls
......................................................................


Reduction of renderContents calls

There is no need to call renderContents in ContentBranchNode constructor
because it is going to be called anyways in onSplice

Change-Id: Id1ab983668299658ecd6e89a37667cc34c701689
---
M modules/ve/ce/ve.ce.ContentBranchNode.js
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/ve/ce/ve.ce.ContentBranchNode.js 
b/modules/ve/ce/ve.ce.ContentBranchNode.js
index 0e5f4d5..e1b9ca2 100644
--- a/modules/ve/ce/ve.ce.ContentBranchNode.js
+++ b/modules/ve/ce/ve.ce.ContentBranchNode.js
@@ -25,9 +25,6 @@
 
        // Events
        this.connect( this, { 'childUpdate': 'onChildUpdate' } );
-
-       // Initialization
-       this.renderContents();
 };
 
 /* Inheritance */

-- 
To view, visit https://gerrit.wikimedia.org/r/63096
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id1ab983668299658ecd6e89a37667cc34c701689
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to