jenkins-bot has submitted this change and it was merged.
Change subject: Clone template dom elements being sent to converter
......................................................................
Clone template dom elements being sent to converter
The dom elements in the IV store are used for rendering, so if they
are sent by reference to the converter they get re-attached, causing
all templates to disappear from the page whenever you press 'review
and save'.
Fix is to run it through ve.copyArray, which clones all the nodes.
Change-Id: I1b03351a28ac82e0fdb7e94e761cf65d6548e501
---
M modules/ve/dm/nodes/ve.dm.MWTemplateNode.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/dm/nodes/ve.dm.MWTemplateNode.js
b/modules/ve/dm/nodes/ve.dm.MWTemplateNode.js
index b48e71c..bbd1df6 100644
--- a/modules/ve/dm/nodes/ve.dm.MWTemplateNode.js
+++ b/modules/ve/dm/nodes/ve.dm.MWTemplateNode.js
@@ -70,7 +70,8 @@
if ( ve.compareObjects( dataElement.attributes.mw,
dataElement.attributes.mwOriginal ) ) {
// If the template is unchanged just send back the original dom
elements so selser can skip over it
index = converter.getStore().indexOfHash( ve.getHash(
this.getHashObject( dataElement ) ) );
- return converter.getStore().value( index );
+ // The object in the store is also used for rendering so return
a copy
+ return ve.copyArray( converter.getStore().value( index ) );
} else {
span = doc.createElement( 'span' );
// All we need to send back to Parsoid is the original template
marker,
--
To view, visit https://gerrit.wikimedia.org/r/62971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b03351a28ac82e0fdb7e94e761cf65d6548e501
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
