jenkins-bot has submitted this change and it was merged.
Change subject: Clean up variable initialization in setupSkinTabs()
......................................................................
Clean up variable initialization in setupSkinTabs()
Change-Id: Ic596f1c98162557f33f5ca398d2358e91a3d5cb0
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index 0b34656..846633c 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -759,20 +759,19 @@
* @method
*/
ve.init.mw.ViewPageTarget.prototype.setupSkinTabs = function () {
- var action, pTabsId, $caSource, $caEdit, $caEditLink, caVeEdit,
caVeEditSource, caVeEditNextnode, uriClone;
- $caEdit = $( '#ca-edit' );
- $caEditLink = $caEdit.find( 'a' );
- $caSource = $( '#ca-viewsource' );
- caVeEditNextnode = $caEdit.next().get( 0 );
+ var caVeEdit, caVeEditSource, uriClone,
+ action = this.pageExists ? 'edit' : 'create',
+ pTabsId = $( '#p-views' ).length ? 'p-views' : 'p-cactions',
+ $caSource = $( '#ca-viewsource' ),
+ $caEdit = $( '#ca-edit' ),
+ $caEditLink = $caEdit.find( 'a' ),
+ caVeEditNextnode = $caEdit.next().get( 0 );
if ( !$caEdit.length || $caSource.length ) {
// If there is no edit tab or a view-source tab,
// the user doesn't have permission to edit.
return;
}
-
- action = this.pageExists ? 'edit' : 'create';
- pTabsId = $( '#p-views' ).length ? 'p-views' : 'p-cactions';
// Add independent "VisualEditor" tab (#ca-ve-edit).
if ( this.tabLayout === 'add' ) {
--
To view, visit https://gerrit.wikimedia.org/r/63152
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic596f1c98162557f33f5ca398d2358e91a3d5cb0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
