jenkins-bot has submitted this change and it was merged. Change subject: Edit and Edit source tab were reversed in RTL in the Vector integration ......................................................................
Edit and Edit source tab were reversed in RTL in the Vector integration If we're in RTL mode and the skin is Vector-based, we need to reverse the order of the tabs in the DOM, because that's a weird thing that Vector does to render tabs in RTL. See https://bugzilla.wikimedia.org/show_bug.cgi?id=46947 for discussion about the Vector behavior. Bug: 48017 Change-Id: Ie1214b08450aefed893739a2b862cb1e9b23a2ef --- M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Trevor Parscal: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js index 846633c..bd19803 100644 --- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js @@ -765,7 +765,8 @@ $caSource = $( '#ca-viewsource' ), $caEdit = $( '#ca-edit' ), $caEditLink = $caEdit.find( 'a' ), - caVeEditNextnode = $caEdit.next().get( 0 ); + reverseTabOrder = $( 'body' ).hasClass( 'rtl' ) && pTabsId === 'p-views', + caVeEditNextnode = reverseTabOrder ? $caEdit.get( 0 ) : $caEdit.next().get( 0 ); if ( !$caEdit.length || $caSource.length ) { // If there is no edit tab or a view-source tab, @@ -823,7 +824,7 @@ $caEdit.attr( 'id' ), $caEditLink.attr( 'title' ), $caEditLink.attr( 'accesskey' ), - caVeEditSource + reverseTabOrder ? caVeEditSource.nextSibling : caVeEditSource ); } -- To view, visit https://gerrit.wikimedia.org/r/63153 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1214b08450aefed893739a2b862cb1e9b23a2ef Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
