jenkins-bot has submitted this change and it was merged.
Change subject: Access keys for edit and edit source
......................................................................
Access keys for edit and edit source
Set up 'v' for edit, and 'e' for edit source as access keys.
Bug: 48107
Change-Id: I598177bc75ed84dea35952a3b2b1b2111aac89b2
---
M VisualEditor.i18n.php
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/VisualEditor.i18n.php b/VisualEditor.i18n.php
index 8373d8f..7bc1902 100644
--- a/VisualEditor.i18n.php
+++ b/VisualEditor.i18n.php
@@ -5,8 +5,8 @@
* @author Trevor Parscal
*/
$messages['en'] = array(
- 'accesskey-ca-editsource' => '',
- 'accesskey-ca-ve-edit' => '',
+ 'accesskey-ca-editsource' => 'e',
+ 'accesskey-ca-ve-edit' => 'v',
'tag-visualeditor' => '[[Special:Tags|Tag]]:
[[{{MediaWiki:Visualeditor-descriptionpagelink}}|VisualEditor]]',
'tag-visualeditor-description' => 'Edit made using the
[[{{MediaWiki:Visualeditor-descriptionpagelink}}|VisualEditor]]',
'tooltip-ca-editsource' => 'Edit the source code of this page',
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index b2b1173..c2aea94 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -821,7 +821,7 @@
$caEditLink.text(),
$caEdit.attr( 'id' ),
$caEditLink.attr( 'title' ),
- $caEditLink.attr( 'accesskey' ),
+ ve.msg( 'accesskey-ca-ve-edit' ),
reverseTabOrder ? caVeEditSource.nextSibling :
caVeEditSource
);
}
--
To view, visit https://gerrit.wikimedia.org/r/63231
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I598177bc75ed84dea35952a3b2b1b2111aac89b2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
