Karim.rayani has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/63276


Change subject: Feature: Print/export section expand collapse
......................................................................

Feature: Print/export section expand collapse

Tests have been failing because expanding and collapsing Print/export section 
does not work at times

Bug: 48225
Change-Id: Ie3bb592fe09fdc781a724383fa262f4eb8b1ea7d
---
M features/step_definitions/print_export_menu_steps.rb
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/qa/browsertests 
refs/changes/76/63276/1

diff --git a/features/step_definitions/print_export_menu_steps.rb 
b/features/step_definitions/print_export_menu_steps.rb
index 8c9e1a2..9169504 100644
--- a/features/step_definitions/print_export_menu_steps.rb
+++ b/features/step_definitions/print_export_menu_steps.rb
@@ -2,7 +2,6 @@
   (@browser.div(id: 'p-coll-print_export').attribute_value "class").should == 
"portal collapsed"
   (@browser.div(id: 'p-coll-print_export').div(class: 'body').style 
"display").should == "none"
   hash_cookies = @browser.cookies.to_a
-  flag_print_export_cookie = false
   flag_print_export_cookie_value = ""
   if hash_cookies.size > 0
     for i in 0...hash_cookies.size
@@ -18,8 +17,7 @@
   (@browser.div(id: 'p-coll-print_export').attribute_value "class").should == 
"portal expanded"
   (@browser.div(id: 'p-coll-print_export').div(class: 'body').style 
"display").should == "block"
   hash_cookies = @browser.cookies.to_a
-  flag_print_export_cookie = false
-  flag_print_export_cookie_value = false
+  flag_print_export_cookie_value = ""
   if hash_cookies.size > 0
     for i in 0...hash_cookies.size
       if (hash_cookies[i][:name]).eql? "vector-nav-p-coll-print_export"

-- 
To view, visit https://gerrit.wikimedia.org/r/63276
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3bb592fe09fdc781a724383fa262f4eb8b1ea7d
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Karim.rayani <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to