Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63558
Change subject: 'mediawiki_errors' should not be included by the main EL class
......................................................................
'mediawiki_errors' should not be included by the main EL class
The 'eventlogging::mediawiki_errors' class represents a discrete role that
happens to currently be fulfilled by Vanadium but is not in principle coupled
to the rest of the EventLogging set-up. Declaring it as a dependency of the
main eventlogging class makes EventLogging difficult to port to labs.
'mediawiki_errors' should have a role class, but I'm deferring that work for
now.
Change-Id: I147e9324f5636962a93c1a0bec55444dfff2621b
---
M manifests/site.pp
M modules/eventlogging/manifests/init.pp
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/58/63558/1
diff --git a/manifests/site.pp b/manifests/site.pp
index 624e2df..c1fb94d 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -2772,6 +2772,7 @@
include standard,
role::logging::eventlogging,
+ eventlogging::mediawiki_errors,
nrpe,
role::solr::ttm
diff --git a/modules/eventlogging/manifests/init.pp
b/modules/eventlogging/manifests/init.pp
index 7495089..bd05e45 100644
--- a/modules/eventlogging/manifests/init.pp
+++ b/modules/eventlogging/manifests/init.pp
@@ -15,8 +15,6 @@
auth => true,
}
- class { 'eventlogging::mediawiki_errors': }
-
package { [
'python-jsonschema',
'python-mysqldb',
--
To view, visit https://gerrit.wikimedia.org/r/63558
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I147e9324f5636962a93c1a0bec55444dfff2621b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
