Raimond Spekking has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/63642


Change subject: I18n review in preparation for adding extension to 
translatewiki.net
......................................................................

I18n review in preparation for adding extension to translatewiki.net

i18 file:
* Use single ' instead of " where possible in i18n file
* Add description message
* Add user right message
* In German section: Use UTF-8
* Add some FIXME's

FIXME's:
* Define default values for globals like $ctAllowedGroup
* Use 'communitytwitter-' as message key prefix to avoid conflicts with other 
Twitter extensions
* Add message documentation, see 
https://www.mediawiki.org/wiki/I18n#Message_documentation

Once this is done, I will add extension to translatewiki.net

Change-Id: I5e2e1350ab486814cb93fb9740abb4ad9aa7ddd2
---
M Twitter.i18n.php
M Twitter.php
2 files changed, 63 insertions(+), 49 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CommunityTwitter 
refs/changes/42/63642/1

diff --git a/Twitter.i18n.php b/Twitter.i18n.php
index d04191b..cbb3346 100755
--- a/Twitter.i18n.php
+++ b/Twitter.i18n.php
@@ -38,57 +38,69 @@
 
 $messages = array();
 
+# FIXME's:
+## Use 'communitytwitter-' as message key prefix to avoid conflicts with other 
Twitter extensions
+## Add message documentation, see 
https://www.mediawiki.org/wiki/I18n#Message_documentation
+
 // English
-$messages["en"] = array(
-       "twitter" => "Twitter",
-       "twitter_no_db_connection" => "No DB connection possible.",
-       "twitter_no_db" => "DB does not exist.",
-       "twitter_unknown_error" => "Either you were blocked/your account not 
set up or an unknown error occurred.<br /><br />In case you think you should 
have access, please contact <a href=\"./Benutzer:Basti\">Basti</a>.",
-       "twitter_connection_failure" => "Connection to Twitter could not be 
established.",
-       "twitter_tweet_section_title" => "Tweet!",
-       "twitter_logged_in_as" => "Logged in as user",
-       "twitter_update_success" => "Status successfully updated",
-       "twitter_check_tweet" => "see",
-       "twitter_unknown_error_request" => "An error occurred during the 
communication with Twitter. You can contact <a 
href=\"./Benutzer:Basti\">Basti</a> if this happens repeatedly.",
-       "twitter_tweet_too_long" => "Tweets are limited to 140 characters.",
-       "twitter_deletion_success" => "Tweet successfully deleted.",
-       "twitter_deletion_tweet_not_found" => "A Tweet with the given ID does 
not exist.",
-       "twitter_remaining_chars" => "Characters left",
-       "twitter_your_last_tweets" => "Your last tweets",
-       "twitter_delete_tweet_title_tag" => "Delete tweet",
-       "twitter_delete_tweet_link_name" => "delete",
-       "twitter_no_last_tweets" => "No tweets available",
-       "twitter_description_template" => "Hickernews-Beschreibung",
-       "twitter_advice_template" => "Hickernews-Hinweise",
-       "twitter_access_error" => "You have to be <span class=\"plainlinks\"><a 
href=\"/wiki/Spezial:UserLogin\" class=\"external text\" title=\"log in\" 
rel=\"nofollow\">logged in</a></span> and \n".
-                                                                               
                                "<span class=\"plainlinks\"><a 
href=\"/wiki/Spezial:Gruppenrechte\" class=\"external text\" title=\"See group 
rights\" \n".
+$messages['en'] = array(
+       'twitter' => 'Twitter',
+       'communitytwitter-desc' => 'Provides a special page, where authorized 
users are able to twitter via a community account without the need of giving 
away login credentials',
+       'twitter_no_db_connection' => 'No database connection possible.',
+       'twitter_no_db' => 'Database does not exist.',
+       'twitter_unknown_error' => 'Either you were blocked/your account is not 
set up or an unknown error occurred.
+
+In case you think you should have access, please contact <a 
href=\'./Benutzer:Basti\'>Basti</a>.', # FIXME: Replace username with a more 
generic link.
+       'twitter_connection_failure' => 'Connection to Twitter could not be 
established.',
+       'twitter_tweet_section_title' => 'Tweet!',
+       'twitter_logged_in_as' => 'Logged in as user',
+       'twitter_update_success' => 'Status successfully updated',
+       'twitter_check_tweet' => 'see',
+       'twitter_unknown_error_request' => 'An error occurred during the 
communication with Twitter. You can contact <a 
href=\'./Benutzer:Basti\'>Basti</a> if this happens repeatedly.',
+       'twitter_tweet_too_long' => 'Tweets are limited to 140 characters.',
+       'twitter_deletion_success' => 'Tweet successfully deleted.',
+       'twitter_deletion_tweet_not_found' => 'A Tweet with the given ID does 
not exist.',
+       'twitter_remaining_chars' => 'Characters left',
+       'twitter_your_last_tweets' => 'Your last tweets',
+       'twitter_delete_tweet_title_tag' => 'Delete tweet',
+       'twitter_delete_tweet_link_name' => 'delete',
+       'twitter_no_last_tweets' => 'No tweets available',
+       'twitter_description_template' => 'Hickernews-Beschreibung', # FIXME: 
German -> English
+       'twitter_advice_template' => 'Hickernews-Hinweise', # FIXME: German -> 
English
+       'twitter_access_error' => "You have to be <span class=\"plainlinks\"><a 
href=\"/wiki/Special:UserLogin\" class=\"external text\" title=\"log in\" 
rel=\"nofollow\">logged in</a></span> and \n".
+                                                                               
                                "<span class=\"plainlinks\"><a 
href=\"/wiki/Special:ListGroupRights\" class=\"external text\" title=\"See 
group rights\" \n".
                                                                                
                                "rel=\"nofollow\">allowed</a></span> to access 
this page."
+       'rights-twitter' => 'Use Twitter special page',
 );
+
 // German (Deutsch)
-$messages["de"] = array(
-       "twitter" => "Twitter",
-       "twitter_no_db_connection" => "Keine Verbindung zur DB m&ouml;glich.",
-       "twitter_no_db" => "Die Datenbank existiert nicht.",
-       "twitter_unknown_error" => "Entweder wurde dein Zugang zu den 
Hickernews deaktiviert bzw. noch nicht eingerichtet oder ein unbekannter Fehler 
ist aufgetreten.<br /><br />Wenn du glaubst, dass du Zugang zum Hickerspace 
Twitter-Account haben solltest, wende dich an <a 
href=\"./Benutzer:Basti\">Basti</a>.",
-       "twitter_connection_failure" => "Verbindungsaufbau mit Zugangsdaten zu 
Twitter fehlgeschlagen.",
-       "twitter_tweet_section_title" => "Tweet!",
-       "twitter_logged_in_as" => "Eingeloggt als Benutzer",
-       "twitter_update_success" => "Status erfolgreich aktualisiert",
-       "twitter_check_tweet" => "einsehen",
-       "twitter_unknown_error_request" => "Ein Fehler bei der Kommunikation 
mit Twitter ist aufgetreten. Du kannst dich an <a 
href=\"./Benutzer:Basti\">Basti</a> wenden, wenn dieser Fehler wiederholt 
auftritt.",
-       "twitter_tweet_too_long" => "Die Statusmeldung darf nur maximal 140 
Zeichen lang sein.",
-       "twitter_deletion_success" => "Tweet erfolgreich gel&ouml;scht.",
-       "twitter_deletion_tweet_not_found" => "Ein Tweet von dir mit dieser ID 
existiert nicht.",
-       "twitter_remaining_chars" => "Verbleibende Zeichen",
-       "twitter_your_last_tweets" => "Deine letzten Tweets",
-       "twitter_delete_tweet_title_tag" => "Tweet l&ouml;schen",
-       "twitter_delete_tweet_link_name" => "l&ouml;schen",
-       "twitter_no_last_tweets" => "keine Tweets verf&uuml;gbar",
-       "twitter_description_template" => "Hickernews-Beschreibung",
-       "twitter_advice_template" => "Hickernews-Hinweise",
-       "twitter_access_error" => "Du musst <span class=\"plainlinks\"><a 
href=\"/wiki/Spezial:UserLogin\" class=\"external text\" title=\"Anmelden\" 
rel=\"nofollow\">angemeldet</a></span> sein und \n".
+$messages['de'] = array(
+       'twitter' => 'Twitter',
+       'twitter_no_db_connection' => 'Keine Verbindung zur Datenbank möglich.',
+       'twitter_no_db' => 'Die Datenbank existiert nicht.',
+       'twitter_unknown_error' => 'Entweder wurde dein Zugang zu den 
Hickernews deaktiviert bzw. noch nicht eingerichtet oder ein unbekannter Fehler 
ist aufgetreten.
+
+Wenn du glaubst, dass du Zugang zum Hickerspace Twitter-Account haben 
solltest, wende dich an <a href=\"./Benutzer:Basti\">Basti</a>.',
+       'twitter_connection_failure' => 'Verbindungsaufbau mit Zugangsdaten zu 
Twitter fehlgeschlagen.',
+       'twitter_tweet_section_title' => 'Tweet!',
+       'twitter_logged_in_as' => 'Eingeloggt als Benutzer',
+       'twitter_update_success' => 'Status erfolgreich aktualisiert',
+       'twitter_check_tweet' => 'einsehen',
+       'twitter_unknown_error_request' => 'Ein Fehler bei der Kommunikation 
mit Twitter ist aufgetreten. Du kannst dich an <a 
href=\"./Benutzer:Basti\">Basti</a> wenden, wenn dieser Fehler wiederholt 
auftritt.',
+       'twitter_tweet_too_long' => 'Die Statusmeldung darf nur maximal 140 
Zeichen lang sein.',
+       'twitter_deletion_success' => 'Tweet erfolgreich gelöscht.',
+       'twitter_deletion_tweet_not_found' => 'Ein Tweet von dir mit dieser ID 
existiert nicht.',
+       'twitter_remaining_chars' => 'Verbleibende Zeichen',
+       'twitter_your_last_tweets' => 'Deine letzten Tweets',
+       'twitter_delete_tweet_title_tag' => 'Tweet löschen',
+       'twitter_delete_tweet_link_name' => 'löschen',
+       'twitter_no_last_tweets' => 'keine Tweets verfügbar',
+       'twitter_description_template' => 'Hickernews-Beschreibung',
+       'twitter_advice_template' => 'Hickernews-Hinweise',
+       'twitter_access_error' => "Du musst <span class=\"plainlinks\"><a 
href=\"/wiki/Spezial:UserLogin\" class=\"external text\" title=\"Anmelden\" 
rel=\"nofollow\">angemeldet</a></span> sein und \n".
                                                                                
                                "&uuml;ber die entsprechenden <span 
class=\"plainlinks\"><a href=\"/wiki/Spezial:Gruppenrechte\" class=\"external 
text\" title=\"Benutzergruppen-Rechte einsehen\" \n".
                                                                                
                                "rel=\"nofollow\">Rechte</a></span> 
verf&uuml;gen, um diese Seite sehen zu k&ouml;nnen.",
-       "twitter_id_help_link" => "Wo finde ich die ID?",
-       "twitter_id_help_text" => "Die Tweet-ID findet sich im Twitter-Link der 
zu retweetenden Nachricht. Beispiel: 
http://twitter.com/Hickernews/status/15036238117478400 (Tweet-Id: 
15036238117478400)."
+       'twitter_id_help_link' => 'Wo finde ich die ID?',
+       'twitter_id_help_text' => 'Die Tweet-ID findet sich im Twitter-Link der 
zu retweetenden Nachricht. Beispiel: 
http://twitter.com/Hickernews/status/15036238117478400 (Tweet-Id: 
15036238117478400).'
 );
+
diff --git a/Twitter.php b/Twitter.php
index 49a899b..6fce0f9 100755
--- a/Twitter.php
+++ b/Twitter.php
@@ -36,10 +36,12 @@
        'name' => 'Community Twitter',
        'version' => '0.2',
        'author' => 'Basti',
-       'url' => 'http://hickerspace.org/wiki/Community_Twitter_Extension',
-       'description'  => 'Provides a special page, where special users are 
able to twitter via a community account without the need of giving away login 
credentials.',
+       'url' => 'https://www.mediawiki.org/wiki/Extension:Community_Twitter',
+       'descriptionmsg'  => 'communitytwitter-desc',
 );
 
+# FIXME: Define default values for globals like $ctAllowedGroup
+
 $wgtwitterIP = dirname( __FILE__ ) . '/';
 $wgExtensionMessagesFiles['twitter'] = $wgtwitterIP . 'Twitter.i18n.php';
 $wgSpecialPages['twitter'] = 'twitter';

-- 
To view, visit https://gerrit.wikimedia.org/r/63642
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e2e1350ab486814cb93fb9740abb4ad9aa7ddd2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CommunityTwitter
Gerrit-Branch: master
Gerrit-Owner: Raimond Spekking <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to