Jdlrobson has submitted this change and it was merged.
Change subject: Don't add parent property to Overlay's prototype
......................................................................
Don't add parent property to Overlay's prototype
It should be per instance and is set in line 71 anyway.
Change-Id: If31055991f7060d02bb6349fee12619d10e6d612
---
M javascripts/common/mf-navigation.js
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Jdlrobson: Verified; Looks good to me, approved
diff --git a/javascripts/common/mf-navigation.js
b/javascripts/common/mf-navigation.js
index 9541c3f..7278a50 100644
--- a/javascripts/common/mf-navigation.js
+++ b/javascripts/common/mf-navigation.js
@@ -64,7 +64,6 @@
content: '',
closeMsg: mw.msg( 'mobile-frontend-overlay-escape' )
},
- parent: null,
template: M.template.get( 'overlay' ),
className: 'mw-mf-overlay',
initialize: function( options ) {
--
To view, visit https://gerrit.wikimedia.org/r/63599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If31055991f7060d02bb6349fee12619d10e6d612
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
