Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/63883


Change subject: Code cleanup: [ '..' ] to ['']
......................................................................

Code cleanup: [ '..' ] to ['']

Address FIXME

Change-Id: I0f42c06d084c9cce5094d4d499ca2c077714bbce
---
M includes/MobileFrontend.hooks.php
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/83/63883/1

diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index df7cb9b..7e98a74 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -67,19 +67,18 @@
         * @return boolean
         */
        public static function onMakeGlobalVariablesScript( &$vars, $out ) {
-               // FIXME: replace instances of [ '' ] with ['']
                $skin = $out->getSkin()->getSkinName();
                if ( $skin === 'minerva' ) {
                        $title = $out->getTitle();
                        $user = $out->getUser();
                        if ( !$user->isAnon() ) {
-                               $vars[ 'wgWatchedPageCache' ] = array(
+                               $vars['wgWatchedPageCache'] = array(
                                        $title->getText() => $user->isWatched( 
$title ),
                                );
                        }
 
-                       $vars[ 'wgIsPageEditable' ] = $user->isAllowed( 'edit' 
) && $title->getNamespace() == NS_MAIN;
-                       $vars[ 'wgPreferredVariant' ] = 
$title->getPageLanguage()->getPreferredVariant();
+                       $vars['wgIsPageEditable'] = $user->isAllowed( 'edit' ) 
&& $title->getNamespace() == NS_MAIN;
+                       $vars['wgPreferredVariant'] = 
$title->getPageLanguage()->getPreferredVariant();
                        $ctx = MobileContext::singleton();
                        // mobile specific config variables
                        if ( $ctx->shouldDisplayMobileView() ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/63883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f42c06d084c9cce5094d4d499ca2c077714bbce
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to