jenkins-bot has submitted this change and it was merged.
Change subject: Emit teardown event before replacing generated content node
content and emit setup event after.
......................................................................
Emit teardown event before replacing generated content node content and emit
setup event after.
Change-Id: I397d4dfb5fd0177255a0b4389ba5380807969ef4
---
M modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
b/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
index 414eefc..a9c2c86 100644
--- a/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
+++ b/modules/ve/ce/nodes/ve.ce.GeneratedContentNode.js
@@ -49,7 +49,9 @@
var store = this.model.doc.getStore(),
index = store.indexOfHash( ve.getHash( this.model ) );
if ( index !== null ) {
+ this.emit( 'teardown' );
this.$.empty().append( store.value( index ) );
+ this.emit( 'setup' );
} else {
this.startGenerating();
this.generateContents()
--
To view, visit https://gerrit.wikimedia.org/r/64011
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I397d4dfb5fd0177255a0b4389ba5380807969ef4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
