jenkins-bot has submitted this change and it was merged.
Change subject: Remove custom search box clear icon
......................................................................
Remove custom search box clear icon
This caused wrong behavior on Internet Explorer. There seems
to be agreement in the bug report comments to remove the custom
functionality and rely on whatever the browsers provide.
Bug: 47038
Change-Id: I468b428a2496a64b56a01fe782762d9805862120
---
M resources/css/ext.translate.special.translate.css
M resources/js/ext.translate.messagetable.js
M specials/SpecialTranslate.php
3 files changed, 2 insertions(+), 24 deletions(-)
Approvals:
Santhosh: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/css/ext.translate.special.translate.css
b/resources/css/ext.translate.special.translate.css
index 43f7e6a..36f14e7 100644
--- a/resources/css/ext.translate.special.translate.css
+++ b/resources/css/ext.translate.special.translate.css
@@ -171,16 +171,3 @@
position: relative;
left: -5px;
}
-
-.tux-messagetable-header span.tux-message-filter-box-clear {
- /* @embed */
- background: url('../images/close.png') no-repeat scroll center center
transparent;
- background-image: -webkit-linear-gradient(transparent, transparent),
url(../images/close.svg);
- background-image: -moz-linear-gradient(transparent, transparent),
url(../images/close.svg);
- background-image: linear-gradient(transparent, transparent),
url(../images/close.svg);
- cursor: pointer;
- height: 32px;
- position: absolute;
- width: 32px;
- margin-left: -24px;
-}
diff --git a/resources/js/ext.translate.messagetable.js
b/resources/js/ext.translate.messagetable.js
index e42c084..70671e7 100644
--- a/resources/js/ext.translate.messagetable.js
+++ b/resources/js/ext.translate.messagetable.js
@@ -125,10 +125,6 @@
}, 300 );
} );
- $( '.tux-message-filter-box-clear' ).on( 'click',
function () {
- $filterInput.focus().val( '' ).trigger( 'input'
);
- } );
-
this.$container.on( 'clear', $.proxy(
messageTable.clear, messageTable ) );
this.$loader.appear( function () {
@@ -357,7 +353,6 @@
if ( !query ) {
$result.addClass( 'hide' );
- $( '.tux-message-filter-box-clear' ).addClass(
'hide' );
} else {
$result.removeClass( 'hide' )
.find( 'div' )
@@ -366,7 +361,6 @@
window.location.href = new mw.Uri(
mw.util.wikiGetlink( 'Special:SearchTranslations' ) )
.extend( { query: query } );
} );
- $( '.tux-message-filter-box-clear'
).removeClass( 'hide' );
}
this.$loader.trigger( 'appear' );
diff --git a/specials/SpecialTranslate.php b/specials/SpecialTranslate.php
index d4c7802..871a23a 100644
--- a/specials/SpecialTranslate.php
+++ b/specials/SpecialTranslate.php
@@ -518,12 +518,9 @@
$output .= Html::element( 'span', array( 'class' => 'two
columns tux-message-filter-box-icon' ) );
$output .= Html::element( 'input', array(
'class' => 'ten columns tux-message-filter-box',
- 'type' => 'text',
+ 'type' => 'search',
) );
- $output .= Html::element(
- 'span',
- array( 'class' => 'one columns
tux-message-filter-box-clear hide' )
- );
+
$output .= Html::closeElement( 'div' ); // close three columns
$output .= Html::closeElement( 'div' ); // close the row
--
To view, visit https://gerrit.wikimedia.org/r/63856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I468b428a2496a64b56a01fe782762d9805862120
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
