Krinkle has submitted this change and it was merged.
Change subject: Disable Generic.CodeAnalysis.UnusedFunctionParameter
......................................................................
Disable Generic.CodeAnalysis.UnusedFunctionParameter
Change-Id: I6e587bf0e7eecd60f0d12afa937907b27d86c353
---
M MediaWiki/ruleset.xml
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Krinkle: Verified; Looks good to me, approved
diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml
index 06b3213..ff21bdd 100644
--- a/MediaWiki/ruleset.xml
+++ b/MediaWiki/ruleset.xml
@@ -13,7 +13,10 @@
<rule ref="Generic.CodeAnalysis.JumbledIncrementer" />
<rule ref="Generic.CodeAnalysis.UnconditionalIfStatement" />
<rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier" />
- <rule ref="Generic.CodeAnalysis.UnusedFunctionParameter" />
+ <!--
+ https://pear.php.net/bugs/bug.php?id=19950
+ <rule ref="Generic.CodeAnalysis.UnusedFunctionParameter" />
+ -->
<rule ref="Generic.CodeAnalysis.UselessOverridingMethod" />
<rule ref="Generic.Files.ByteOrderMark" />
<rule ref="Generic.Files.EndFileNewline" />
--
To view, visit https://gerrit.wikimedia.org/r/64074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e587bf0e7eecd60f0d12afa937907b27d86c353
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
