Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64256
Change subject: Cog icon can be used to close the language settings panel
......................................................................
Cog icon can be used to close the language settings panel
Bug: 47971
Change-Id: I7b6d6142e113bf3f90feef1650bc384a5edc42cb
---
M resources/js/ext.uls.languagesettings.js
1 file changed, 4 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/56/64256/1
diff --git a/resources/js/ext.uls.languagesettings.js
b/resources/js/ext.uls.languagesettings.js
index 6216ac5..888080e 100644
--- a/resources/js/ext.uls.languagesettings.js
+++ b/resources/js/ext.uls.languagesettings.js
@@ -65,7 +65,7 @@
listen: function () {
var langSettings = this;
// Register all event listeners to the ULS language
settings here.
- langSettings.$element.on( 'click', $.proxy(
langSettings.show, langSettings ) );
+ langSettings.$element.on( 'click', $.proxy(
langSettings.click, langSettings ) );
langSettings.$window.find( '#languagesettings-close' )
.on( 'click', $.proxy( langSettings.close,
langSettings ) );
@@ -219,7 +219,9 @@
},
click: function () {
- if ( !this.shown ) {
+ if ( this.shown ) {
+ this.hide();
+ } else {
this.show();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/64256
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b6d6142e113bf3f90feef1650bc384a5edc42cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
