jenkins-bot has submitted this change and it was merged.
Change subject: [time.js] Properly pass jQuery as a dependency to Time.js
......................................................................
[time.js] Properly pass jQuery as a dependency to Time.js
Follow-up to c74d9d38ed3787d1bdfd37167fdd276525ff6733 where the dependency has
not been declared
but introduced in the code.
Change-Id: I9aab7f046e27b9432a19acdf3d807b713fbe3ca3
---
M DataValues/DataValues.resources.php
M DataValues/resources/time.js/src/time.Time.js
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Henning Snater: Looks good to me, approved
jenkins-bot: Verified
diff --git a/DataValues/DataValues.resources.php
b/DataValues/DataValues.resources.php
index 69121ae..9174296 100644
--- a/DataValues/DataValues.resources.php
+++ b/DataValues/DataValues.resources.php
@@ -91,6 +91,9 @@
'time.js/src/time.js',
'time.js/src/time.Time.js',
'time.js/src/time.Time.parse.js',
+ ),
+ 'dependencies' => array(
+ 'jquery',
)
),
diff --git a/DataValues/resources/time.js/src/time.Time.js
b/DataValues/resources/time.js/src/time.Time.js
index 10ea609..a2f6b83 100644
--- a/DataValues/resources/time.js/src/time.Time.js
+++ b/DataValues/resources/time.js/src/time.Time.js
@@ -1,6 +1,9 @@
/**
* time.js's Time constructor for parsing and representing a time.
*
+ * @dependency jQuery
+ * TODO: get rid of heavy jQuery dependency
+ *
* @since 0.1
* @file
* @ingroup Time.js
@@ -9,7 +12,7 @@
* @author Denny Vrandečić
* @author Daniel Werner < [email protected] >
*/
-time.Time = ( function( time ) {
+time.Time = ( function( time, $ ) {
'use strict';
/**
@@ -202,4 +205,4 @@
return Time; // expose time.Time
-}( time ) );
+}( time, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/63985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9aab7f046e27b9432a19acdf3d807b713fbe3ca3
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <[email protected]>
Gerrit-Reviewer: Henning Snater <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
