Daniel Werner has submitted this change and it was merged.
Change subject: Using Proper event namespaces in the snak type selector widget
......................................................................
Using Proper event namespaces in the snak type selector widget
Change-Id: I941ccefec46cb0bb6fdaaee6208f1177c4a19477
---
M
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Daniel Werner: Verified; Looks good to me, approved
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
index 24009a6..3103f9d 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js
@@ -62,6 +62,7 @@
*/
_create: function() {
var self = this,
+ widgetName = this.widgetName,
$menu = this._buildMenu().appendTo( 'body'
).hide();
this._menu = $menu.data( 'menu' );
@@ -69,13 +70,13 @@
// TODO: add a title message
this.element
.addClass( 'ui-state-default ' + this.widgetBaseClass )
- .on( 'mouseover', function( event ) {
+ .on( 'mouseover.' + widgetName, function( event ) {
self.element.addClass( 'ui-state-hover' )
} )
- .on( 'mouseout', function( event ) {
+ .on( 'mouseout.' + widgetName, function( event ) {
self.element.removeClass( 'ui-state-hover' )
} )
- .on( 'click.wb-snaktypeselector', function( event ) {
+ .on( 'click.' + widgetName, function( event ) {
// don't show menu if selector is disabled!
// otherwise, simply toggle menu's visibility
if( self.isDisabled() || $menu.is( ':visible' )
) {
@@ -101,11 +102,12 @@
self._unbindGlobalListenersFn = function() {
// unbind event after closing menu,
explicitly unbind specific handler to
// support instantiation of multiple
snaktypeselector widgets.
- $( document ).add( $( window ) ).off(
'mouseup resize', degrade );
+ $( document ).add( $( window ) )
+ .off( 'mouseup.' + widgetName +
'resize.' + widgetName, degrade );
self._unbindGlobalListenersFn = $.noop;
};
- $( document ).on(
'mouseup.wb-snaktypeselector', degrade );
- $( window ).on( 'resize.wb-snaktypeselector',
degrade );
+ $( document ).on( 'mouseup.' + widgetName,
degrade );
+ $( window ).on( 'resize.' + widgetName, degrade
);
} );
this.$icon = $( '<span/>' )
--
To view, visit https://gerrit.wikimedia.org/r/63869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I941ccefec46cb0bb6fdaaee6208f1177c4a19477
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
Gerrit-Reviewer: Daniel Werner <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
