Andrew Bogott has submitted this change and it was merged.
Change subject: Clean up a couple of bad calls to printDebug().
......................................................................
Clean up a couple of bad calls to printDebug().
Also removed reference to an obsolete variable in
getNextIdNumber()
Change-Id: Iecf42ca8f055457b542a26cf85839019bb2fb136
---
M nova/OpenStackNovaUser.php
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Andrew Bogott: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/nova/OpenStackNovaUser.php b/nova/OpenStackNovaUser.php
index 0ac054c..e93fc55 100644
--- a/nova/OpenStackNovaUser.php
+++ b/nova/OpenStackNovaUser.php
@@ -372,7 +372,6 @@
* @static
* @param $auth
* @param $attr
- * @param $projectDN (optional)
* @return mixed|string
*/
static function getNextIdNumber( $auth, $attr ) {
@@ -410,7 +409,7 @@
$auth->printDebug( "Failed to get a result searching
for next $attr", NONSENSITIVE );
}
- if ( $projectDN && $highest >
$wgOpenStackManagerIdRanges['service']['gid']['max']) {
+ if ( $highest >
$wgOpenStackManagerIdRanges['service']['gid']['max']) {
$auth->printDebug( "Ran out of service group gids!",
NONSENSITIVE );
}
@@ -428,14 +427,14 @@
*/
static function RequestShellAccess( $auth, $username ) {
- $auth->printDebug( "Autogenerating shell access request for " .
$username );
+ $auth->printDebug( "Autogenerating shell access request for " .
$username, NONSENSITIVE );
$titletext = "Shell_Request/" . $username;
$title = Title::newFromText( $titletext );
$article = WikiPage::factory( $title );
if ( $article->exists() ) {
- $auth->printDebug( "shell request for " . $username . "
already exists." );
+ $auth->printDebug( "shell request for " . $username . "
already exists.", NONSENSITIVE );
return false;
}
--
To view, visit https://gerrit.wikimedia.org/r/64061
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecf42ca8f055457b542a26cf85839019bb2fb136
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OpenStackManager
Gerrit-Branch: master
Gerrit-Owner: Andrew Bogott <[email protected]>
Gerrit-Reviewer: Andrew Bogott <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
