Faidon has submitted this change and it was merged.
Change subject: Varnish: remove send_timeout=30, rely on the default (600s)
......................................................................
Varnish: remove send_timeout=30, rely on the default (600s)
Varnish 3.0.3 introduced idle_send_timeout with a default value of 60,
and increased send_timeout's default to 600, from 60. We had
send_timeout set to 30s, but the codepath where is this is checked is
after idle_send_timeout (SO_SNDTIMEO) fires, so effectively send_timeout
was implicitly set to 60s.
This means that connections were reset after 60s, regardless of their
activity. For this to trigger, 60s had to pass before the TCP send
buffer emptied, which is set to 16MB in our case.
The end-user effect of all this is clients with connections slower than
~270K/s had issues (connection reset) fetching files that needed more
than 60s to finish (i.e. 16MB at 270K/s, 8MB at 135K/s and so on).
This doesn't actually retroactively apply it, so we'll also need a
varnishadm param.set on all Varnish frontend/backends.
Fixes RT #5170 / bug #48353.
Change-Id: I7407613912c49bba583768cb7e27b531e1e95647
---
M templates/varnish/varnish-default.erb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Faidon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/templates/varnish/varnish-default.erb
b/templates/varnish/varnish-default.erb
index b1106fc..ef795de 100644
--- a/templates/varnish/varnish-default.erb
+++ b/templates/varnish/varnish-default.erb
@@ -104,7 +104,7 @@
# -s ${VARNISH_STORAGE}"
#
-EXTRA_OPTS="-p user=varnish -p thread_pool_add_delay=1 -p
thread_pool_stack=131072 -p send_timeout=30 -p listen_depth=4096 -p
session_max=200000 -p vcc_err_unref=off -p nuke_limit=300 -p shm_reclen=1024
<%= runtime_params %>"
+EXTRA_OPTS="-p user=varnish -p thread_pool_add_delay=1 -p
thread_pool_stack=131072 -p listen_depth=4096 -p session_max=200000 -p
vcc_err_unref=off -p nuke_limit=300 -p shm_reclen=1024 <%= runtime_params %>"
<% if has_variable?("extraopts") then %>
EXTRA_OPTS="$EXTRA_OPTS <%= extraopts %>"
<% end %>
--
To view, visit https://gerrit.wikimedia.org/r/64314
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7407613912c49bba583768cb7e27b531e1e95647
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon <[email protected]>
Gerrit-Reviewer: Faidon <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
