Milimetric has submitted this change and it was merged.
Change subject: adds unicode test file which includes a user_id
......................................................................
adds unicode test file which includes a user_id
fixes bug which breaks upload when using user_ids
Change-Id: Iadada3f224a34970541f20c333ed37189f945487
---
M user_metrics/query/query_calls_sql.py
A user_metrics/test/unicode_cohort.csv
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Milimetric: Verified; Looks good to me, approved
diff --git a/user_metrics/query/query_calls_sql.py
b/user_metrics/query/query_calls_sql.py
index 680aee2..5663c56 100644
--- a/user_metrics/query/query_calls_sql.py
+++ b/user_metrics/query/query_calls_sql.py
@@ -1075,7 +1075,7 @@
""",
is_valid_uid_query.__name__ :
"""
- SELECT user_id FROM <database>.user
+ SELECT user_name FROM <database>.user
WHERE user_id = %(uid)s
""",
is_valid_username_query.__name__ :
diff --git a/user_metrics/test/unicode_cohort.csv
b/user_metrics/test/unicode_cohort.csv
new file mode 100644
index 0000000..5268781
--- /dev/null
+++ b/user_metrics/test/unicode_cohort.csv
@@ -0,0 +1,4 @@
+تيسير سامى سلامة,ar
+سهام موسى عتما,ar
+نورام الشقيرى,ar
+562526,ar
--
To view, visit https://gerrit.wikimedia.org/r/64315
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iadada3f224a34970541f20c333ed37189f945487
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: master
Gerrit-Owner: Erosen <[email protected]>
Gerrit-Reviewer: Diederik <[email protected]>
Gerrit-Reviewer: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
