Mgrover has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64510
Change subject: Change watchlist tests to use Android 4.1.1 useragent
......................................................................
Change watchlist tests to use Android 4.1.1 useragent
Change-Id: Icc212a1b4eae816058578aee6bc9068d5444f8d8
---
M tests/acceptance/features/step_definitions/watchlist_steps.rb
M tests/acceptance/features/watchlist.feature
2 files changed, 7 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/10/64510/1
diff --git a/tests/acceptance/features/step_definitions/watchlist_steps.rb
b/tests/acceptance/features/step_definitions/watchlist_steps.rb
index 13ea68d..de2ccd1 100644
--- a/tests/acceptance/features/step_definitions/watchlist_steps.rb
+++ b/tests/acceptance/features/step_definitions/watchlist_steps.rb
@@ -5,10 +5,6 @@
end
end
-Given /^I am not logged in$/ do
- # nothing to do here, user in not logged in by default
-end
-
When /^I select the watchlist icon$/ do
on(HomePage).watch_link_element.when_present.click
end
@@ -23,8 +19,6 @@
page.text.should include "Sign in"
end
end
-
-#Signup takes you to the sign in page... should it take you to the Mobile
Create Account page??
Given /^I am logged into the mobile website$/ do
on(HomePage) do |page|
diff --git a/tests/acceptance/features/watchlist.feature
b/tests/acceptance/features/watchlist.feature
index 9a32503..8c26c81 100644
--- a/tests/acceptance/features/watchlist.feature
+++ b/tests/acceptance/features/watchlist.feature
@@ -2,27 +2,28 @@
Feature: Manage Watchlist
Scenario: I receive notification that I need to log in to use the watchlist
functionality
- Given that I am using Mozilla/5.0 (Linux; U; Android 4.0.3; ko-kr;
LG-L160L Build/IML74K) AppleWebkit/534.30 (KHTML, like Gecko) Version/4.0
Mobile Safari/534.30
+ Given that I am using Mozilla/5.0 (Linux; U; Android 4.1.1; en-us; Nexus S
Build/JRO03E) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile
Safari/534.30
And I go to random page
When I select the watchlist icon
Then I receive notification that I need to log in to use the watchlist
functionality
Scenario: Login link leads to login page
- Given that I am using Mozilla/5.0 (Linux; U; Android 4.0.3; ko-kr;
LG-L160L Build/IML74K) AppleWebkit/534.30 (KHTML, like Gecko) Version/4.0
Mobile Safari/534.30
+ Given that I am using Mozilla/5.0 (Linux; U; Android 4.1.1; en-us; Nexus S
Build/JRO03E) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile
Safari/534.30
And I go to random page
When I select the watchlist icon
And I click Login
Then Login page opens
Scenario: Sign up link leads to Sign up page
- Given that I am using Mozilla/5.0 (Linux; U; Android 4.0.3; ko-kr;
LG-L160L Build/IML74K) AppleWebkit/534.30 (KHTML, like Gecko) Version/4.0
Mobile Safari/534.30
+ Given that I am using Mozilla/5.0 (Linux; U; Android 4.1.1; en-us; Nexus S
Build/JRO03E) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile
Safari/534.30
And I go to random page
When I select the watchlist icon
And I click Sign up
Then Sign up page opens
Scenario: Add an article to the watchlist
- Given that I am using Mozilla/5.0 (Linux; U; Android 4.0.3; ko-kr;
LG-L160L Build/IML74K) AppleWebkit/534.30 (KHTML, like Gecko) Version/4.0
Mobile Safari/534.30
+ Given that I am using Mozilla/5.0 (Linux; U; Android 4.1.1; en-us; Nexus S
Build/JRO03E) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile
Safari/534.30
+ And I am on the home page
And I am logged into the mobile website
When I go to random page
And I select the watchlist icon
@@ -30,7 +31,8 @@
And the article watchlist icon is selected
Scenario: Remove an article from the watchlist
- Given that I am using Mozilla/5.0 (Linux; U; Android 4.0.3; ko-kr;
LG-L160L Build/IML74K) AppleWebkit/534.30 (KHTML, like Gecko) Version/4.0
Mobile Safari/534.30
+ Given that I am using Mozilla/5.0 (Linux; U; Android 4.1.1; en-us; Nexus S
Build/JRO03E) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile
Safari/534.30
+ And I am on the home page
And I am logged into the mobile website
When I go to random page
And I select the watchlist icon
--
To view, visit https://gerrit.wikimedia.org/r/64510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc212a1b4eae816058578aee6bc9068d5444f8d8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Mgrover <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
