TheDJ has submitted this change and it was merged.
Change subject: display: inline-block for .errorbox, .warningbox, .successbox
......................................................................
display: inline-block for .errorbox, .warningbox, .successbox
It previously used float: left to generate a box with intrinsic width,
which required the next element to have clear: left to avoid display
quirks. display: inline-block is the proper way to do this.
Includes hacks for IE6 and FF2.
Bug: 33438
Change-Id: Ibb9371eecb99b627ba9dfca5b0a60143fbd6f84f
---
M skins/common/shared.css
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
TheDJ: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/skins/common/shared.css b/skins/common/shared.css
index 8b8706b..fb140b2 100644
--- a/skins/common/shared.css
+++ b/skins/common/shared.css
@@ -543,9 +543,12 @@
font-size: larger;
border: 2px solid;
padding: .5em 1em;
- float: left;
margin-bottom: 2em;
color: #000;
+ display: -moz-inline-block;
+ display: inline-block;
+ zoom: 1;
+ *display: inline;
}
.errorbox {
border-color: red;
--
To view, visit https://gerrit.wikimedia.org/r/62439
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb9371eecb99b627ba9dfca5b0a60143fbd6f84f
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: Spage <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
