Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64558
Change subject: Fix all jshint errors
......................................................................
Fix all jshint errors
Change-Id: Ib8fb350132bb34c1e063eb644af5aeff833f95e8
---
M resources/js/ext.uls.init.js
M resources/js/ext.uls.inputsettings.js
M resources/js/ext.uls.preferences.js
3 files changed, 5 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/58/64558/1
diff --git a/resources/js/ext.uls.init.js b/resources/js/ext.uls.init.js
index 0bc1682..0b1bb2e 100644
--- a/resources/js/ext.uls.init.js
+++ b/resources/js/ext.uls.init.js
@@ -66,6 +66,7 @@
return ( window.navigator.language ||
window.navigator.userLanguage ).split( '-' )[0];
};
+ /*jshint camelcase:false*/
mw.uls.getCountryCode = function () {
return window.Geo && ( window.Geo.country ||
window.Geo.country_code );
};
diff --git a/resources/js/ext.uls.inputsettings.js
b/resources/js/ext.uls.inputsettings.js
index 4684554..250d5bd 100644
--- a/resources/js/ext.uls.inputsettings.js
+++ b/resources/js/ext.uls.inputsettings.js
@@ -478,6 +478,7 @@
// Live ime update
this.$parent.hide();
} else {
+ /*jshint noempty:false*/
// FIXME failure. what to do?!
}
},
diff --git a/resources/js/ext.uls.preferences.js
b/resources/js/ext.uls.preferences.js
index d60bd30..cfefb63 100644
--- a/resources/js/ext.uls.preferences.js
+++ b/resources/js/ext.uls.preferences.js
@@ -167,8 +167,9 @@
* @param callback
*/
save: function ( callback ) {
- var ulsPreferences = this;
-
+ var ulsPreferences = this,
+ successFunction,
+ failFunction;
callback = callback || $.noop;
if ( this.isAnon ) {
@@ -176,7 +177,6 @@
$.jStorage.set( this.preferenceName,
this.preferences );
callback.call( this, true );
} else {
- var successFunction, failFunction;
successFunction = function () {
callback.call( this, true );
--
To view, visit https://gerrit.wikimedia.org/r/64558
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8fb350132bb34c1e063eb644af5aeff833f95e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
