Mdale has submitted this change and it was merged. Change subject: (bug 48300) escape title in edit url ......................................................................
(bug 48300) escape title in edit url escape title with mw.util.wikiUrlencode so creating subtitles works for titles with question marks. Bug: 48300 Change-Id: I6443dceb2f9aa3d6fa7ffe5fafe3ae4c343e06bd --- M TimedTextPage.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mdale: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/TimedTextPage.php b/TimedTextPage.php index 0f6c8e2..865f46a 100644 --- a/TimedTextPage.php +++ b/TimedTextPage.php @@ -161,7 +161,7 @@ 'var articlePath = mw.config.get( "wgArticlePath" );' . 'var paramSep = (articlePath.indexOf("?")===-1) ? "?" : "&";' . 'var title = ' . json_encode( $timedTextTile ) . '.replace("LANG", $("#timedmedia-tt-input").val());'. - 'window.location = articlePath.replace(/\$1/, title + ' . + 'window.location = articlePath.replace(/\$1/, mw.util.wikiUrlencode( title ) + ' . ' paramSep + "action=edit" ) ' . '});' . '});' -- To view, visit https://gerrit.wikimedia.org/r/63417 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6443dceb2f9aa3d6fa7ffe5fafe3ae4c343e06bd Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: J <jger...@wikimedia.org> Gerrit-Reviewer: Mdale <md...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits