Siebrand has uploaded a new change for review. https://gerrit.wikimedia.org/r/64606
Change subject: Update formatting ...................................................................... Update formatting Fixes for issues CodeSniffer complained about at https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-HEAD/9920/console for 4f98011fdd98328028d152baf27627fea0c28d3e. Change-Id: I2cc0cee6ff8260e74ad8b1721614ae16a360e68d --- M includes/SpecialPage.php 1 file changed, 24 insertions(+), 17 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/06/64606/1 diff --git a/includes/SpecialPage.php b/includes/SpecialPage.php index 665ca4a..ac838a5 100644 --- a/includes/SpecialPage.php +++ b/includes/SpecialPage.php @@ -27,7 +27,6 @@ * @ingroup SpecialPage */ class SpecialPage { - // The canonical name of this special page // Also used for the default <h1> heading, @see getDescription() protected $mName; @@ -305,12 +304,14 @@ * If you override execute(), you can recover the default behavior with userCanExecute() * and displayRestrictionError() * - * @param string $name name of the special page, as seen in links and URLs - * @param string $restriction user right required, e.g. "block" or "delete" - * @param bool $listed whether the page is listed in Special:Specialpages - * @param $function Callback|Bool: function called by execute(). By default it is constructed from $name - * @param string $file file which is included by execute(). It is also constructed from $name by default - * @param bool $includable whether the page can be included in normal pages + * @param string $name Name of the special page, as seen in links and URLs + * @param string $restriction User right required, e.g. "block" or "delete" + * @param bool $listed Whether the page is listed in Special:Specialpages + * @param Callback|Bool $function Function called by execute(). By default + * it is constructed from $name + * @param string $file File which is included by execute(). It is also + * constructed from $name by default + * @param bool $includable Whether the page can be included in normal pages */ public function __construct( $name = '', $restriction = '', $listed = true, @@ -322,12 +323,14 @@ /** * Do the real work for the constructor, mainly so __call() can intercept * calls to SpecialPage() - * @param string $name name of the special page, as seen in links and URLs - * @param string $restriction user right required, e.g. "block" or "delete" - * @param bool $listed whether the page is listed in Special:Specialpages - * @param $function Callback|Bool: function called by execute(). By default it is constructed from $name - * @param string $file file which is included by execute(). It is also constructed from $name by default - * @param bool $includable whether the page can be included in normal pages + * @param string $name Name of the special page, as seen in links and URLs + * @param string $restriction User right required, e.g. "block" or "delete" + * @param bool $listed Whether the page is listed in Special:Specialpages + * @param Callback|Bool $function Function called by execute(). By default + * it is constructed from $name + * @param string $file File which is included by execute(). It is also + * constructed from $name by default + * @param bool $includable Whether the page can be included in normal pages */ private function init( $name, $restriction, $listed, $function, $file, $includable ) { $this->mName = $name; @@ -749,7 +752,8 @@ if ( $this->mContext instanceof IContextSource ) { return $this->mContext; } else { - wfDebug( __METHOD__ . " called and \$mContext is null. Return RequestContext::getMain(); for sanity\n" ); + wfDebug( __METHOD__ . " called and \$mContext is null. " . + "Return RequestContext::getMain(); for sanity\n" ); return RequestContext::getMain(); } } @@ -956,7 +960,8 @@ * Play with the HTMLForm if you need to more substantially * @param $form HTMLForm */ - protected function alterForm( HTMLForm $form ) {} + protected function alterForm( HTMLForm $form ) { + } /** * Get message prefix for HTMLForm @@ -1011,7 +1016,8 @@ * confirmation message * @since 1.22 Default is to do nothing */ - public function onSuccess() {} + public function onSuccess() { + } /** * Basic SpecialPage workflow: get a form, send it to the user; get some data back, @@ -1174,6 +1180,7 @@ } abstract class SpecialRedirectToSpecial extends RedirectSpecialPage { + // @todo FIXME: Visibility must be declared var $redirName, $redirSubpage; function __construct( @@ -1250,7 +1257,7 @@ * - limit, offset: Useful for linking to history of one's own user page or * user talk page. For example, this would be a link to "the last edit to your * user talk page in the year 2010": - * http://en.wikipedia.org/w/index.php?title=Special:MyPage&offset=20110000000000&limit=1&action=history + * http://en.wikipedia.org/wiki/Special:MyPage?offset=20110000000000&limit=1&action=history * * - feed: would allow linking to the current user's RSS feed for their user * talk page: -- To view, visit https://gerrit.wikimedia.org/r/64606 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2cc0cee6ff8260e74ad8b1721614ae16a360e68d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Siebrand <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
