jenkins-bot has submitted this change and it was merged.
Change subject: (Bug 48621) TineInput expert updates its rawValue to invalid
values if required
......................................................................
(Bug 48621) TineInput expert updates its rawValue to invalid values if required
Before, when a invalid time was entered, the old, valid time would still be
returned by rawValue().
NOTE: this is not easily testable with QUnit tests since we had to simulate a
user change on the
input widget used by the expert, then check for the change notification
being triggered and
the rawValue() being updated.
Change-Id: Ieb37ba7ea544c37421e38ddef21acef901b26523
---
M ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Tobias Gritschacher: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
b/ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
index 9b3056c..e43ce7c 100644
---
a/ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
+++
b/ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
@@ -207,6 +207,7 @@
self.$precision.data( 'listrotator'
).rotate( value.precision() );
self.$calendar.data( 'listrotator'
).rotate( value.calendarText() );
}
+ self._newValue = false; // value, not yet
handled by draw(), is outdated now
self._viewNotifier.notify( 'change' );
} );
--
To view, visit https://gerrit.wikimedia.org/r/64541
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb37ba7ea544c37421e38ddef21acef901b26523
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
