jenkins-bot has submitted this change and it was merged.
Change subject: Remove redundant focus handler
......................................................................
Remove redundant focus handler
focus on input field and updating language(can be changed from settings,
selector etc) is already handled inside jquery.ime
But focus on the particular input field need to be triggered, without
consuming focus event with in the event handler
Change-Id: I0b3783542e23b194fe141b9aef692a855469ce62
---
M resources/js/ext.uls.ime.js
1 file changed, 2 insertions(+), 9 deletions(-)
Approvals:
Amire80: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.uls.ime.js b/resources/js/ext.uls.ime.js
index 1b71f3d..1841082 100644
--- a/resources/js/ext.uls.ime.js
+++ b/resources/js/ext.uls.ime.js
@@ -139,8 +139,7 @@
mw.ime.setup = function () {
$( 'body' ).on( 'focus.ime', inputSelector, function () {
- var imeselector,
- $input = $( this );
+ var $input = $( this );
$input.ime( {
languages: mw.ime.getIMELanguageList(),
@@ -165,13 +164,7 @@
return $ulsTrigger;
}
- } );
-
- // Some fields may be uninitialized
- imeselector = $input.data( 'imeselector' );
- if ( imeselector ) {
- imeselector.selectLanguage(
$.ime.preferences.getLanguage() );
- }
+ } ).focus();
} );
};
--
To view, visit https://gerrit.wikimedia.org/r/64262
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b3783542e23b194fe141b9aef692a855469ce62
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
