EBernhardson (WMF) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/64953


Change subject: Fix for wrong prefixing of multi checkbox
......................................................................

Fix for wrong prefixing of multi checkbox

Bug: 48693
Change-Id: Ifd8d1d54d5252da958c30cdc0ffa1155ba4cf924
---
M includes/Preferences.php
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/53/64953/1

diff --git a/includes/Preferences.php b/includes/Preferences.php
index 1b01750..226e379 100644
--- a/includes/Preferences.php
+++ b/includes/Preferences.php
@@ -1571,9 +1571,10 @@
                foreach ( $this->mFlatFields as $fieldname => $field ) {
                        if ( $field instanceof HTMLNestedFilterable ) {
                                $info = $field->mParams;
-                               $prefix = isset( $info['prefix'] ) ? 
$info['prefix'] : $fieldname;
+                               $prefix = isset( $info['prefix'] ) ? 
$info['prefix'] : "$fieldname-";
                                foreach ( $field->filterDataForSubmit( 
$data[$fieldname] ) as $key => $value ) {
-                                       $data["$prefix-$key"] = $value;
+                                       wfDebug( "Set $prefix$key to $value" );
+                                       $data["$prefix$key"] = $value;
                                }
                                unset( $data[$fieldname] );
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/64953
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd8d1d54d5252da958c30cdc0ffa1155ba4cf924
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: EBernhardson (WMF) <ebernhard...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to