jenkins-bot has submitted this change and it was merged.
Change subject: Added comment to explain better what ve.Keys is.
......................................................................
Added comment to explain better what ve.Keys is.
Change-Id: I9c9b181c4ddbaa0a32e419726fc91b6ae8db7b2a
---
M modules/ve/ve.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Christian: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ve.js b/modules/ve/ve.js
index 9e87e29..25e105a 100644
--- a/modules/ve/ve.js
+++ b/modules/ve/ve.js
@@ -1157,6 +1157,9 @@
// Based on the KeyEvent DOM Level 3 (add more as you need them)
//
http://www.w3.org/TR/2001/WD-DOM-Level-3-Events-20010410/DOM3-Events.html#events-Events-KeyEvent
// http://www.w3.org/TR/2000/WD-DOM-Level-3-Events-20000901/events.html
+ // Some browsers provide global collection KeyEvent but using it is
unreliable so we are using
+ // our own implementation. (For instance compare how inconsistent is
constant for DOM_VK_RETURN
+ // and DOM_VK_ENTER in two links above.)
ve.Keys = {
'DOM_VK_UNDEFINED': 0x0,
'DOM_VK_RIGHT_ALT': 0x12,
--
To view, visit https://gerrit.wikimedia.org/r/64984
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c9b181c4ddbaa0a32e419726fc91b6ae8db7b2a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Inez <i...@wikia-inc.com>
Gerrit-Reviewer: Christian <christ...@wikia-inc.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
