Tim Landscheidt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65007


Change subject: Fix jsub's dependence on $HOME's existence.
......................................................................

Fix jsub's dependence on $HOME's existence.

$HOME isn't set for CGIs so jsub's output files defaulted to the root
directory and thus caused the jobs to fail.  This fixes only bug
#48726; for submitting jobs from CGIs bug #48722 needs to be addressed
as well.

Bug: 48726
Change-Id: I7d03609b0c901527c0dcd492ba99af64e517a13e
---
M packages/jobutils/usr/local/bin/jsub
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/toollabs 
refs/changes/07/65007/1

diff --git a/packages/jobutils/usr/local/bin/jsub 
b/packages/jobutils/usr/local/bin/jsub
index 08f2cb8..bf37f21 100755
--- a/packages/jobutils/usr/local/bin/jsub
+++ b/packages/jobutils/usr/local/bin/jsub
@@ -125,8 +125,8 @@
 $jobname = $1 if $prog =~ m{([^/.]+)(\.[^/]*)?$};
 $jobname = $qsargs{'-N'} if defined $qsargs{'-N'};
 
-my $err = "$ENV{'HOME'}/$jobname.err";
-my $out = "$ENV{'HOME'}/$jobname.out";
+my $err = (getpwuid ($<)) [7] . '/' . $jobname . '.err';
+my $out = (getpwuid ($<)) [7] . '/' . $jobname . '.out';
 
 $err = $qsargs{'-e'} if defined $qsargs{'-e'};
 $out = $qsargs{'-o'} if defined $qsargs{'-o'};

-- 
To view, visit https://gerrit.wikimedia.org/r/65007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d03609b0c901527c0dcd492ba99af64e517a13e
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to