jenkins-bot has submitted this change and it was merged.

Change subject: Fix the use of globals in ApiQueryTitleBlacklistTest
......................................................................


Fix the use of globals in ApiQueryTitleBlacklistTest

Change-Id: I5461277f06f336142f2de0aaf122a8ea767d74a4
---
M tests/ApiQueryTitleBlacklistTest.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Hashar: Looks good to me, approved
  Jeroen De Dauw: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/tests/ApiQueryTitleBlacklistTest.php 
b/tests/ApiQueryTitleBlacklistTest.php
index 174cfdf..1f8164e 100644
--- a/tests/ApiQueryTitleBlacklistTest.php
+++ b/tests/ApiQueryTitleBlacklistTest.php
@@ -19,7 +19,7 @@
 class ApiQueryTitleBlacklistTest extends ApiTestCase {
 
        function setUp() {
-               global $wgTitleBlacklistSources, $wgGroupPermissions;
+               global $wgTitleBlacklistSources;
                parent::setUp();
                $this->doLogin();
 
@@ -54,6 +54,8 @@
         * Verify tboverride works
         */
        function testTboverride() {
+               global $wgGroupPermissions;
+
                // Allow all users to override the titleblacklist
                $wgGroupPermissions['*']['tboverride'] = true;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/63841
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5461277f06f336142f2de0aaf122a8ea767d74a4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TitleBlacklist
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to