[MediaWiki-commits] [Gerrit] Don't lazy load sections on the first load - change (mediawiki...MobileFrontend)

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65134


Change subject: Don't lazy load sections on the first load
......................................................................

Don't lazy load sections on the first load

Switch focus to lazy page loading due to lack
of traction and apparently unsolveable 'bugs'

See http://osdir.com/ml/general/2013-05/msg36167.html

Renders bug 42746 and bug 41569 invalid

Change-Id: I40ebba95146fbb97db550933bc891ff47aa23324
---
M includes/MobileFrontend.body.php
M javascripts/modules/mf-toggle-dynamic.js
2 files changed, 5 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/34/65134/1

diff --git a/includes/MobileFrontend.body.php b/includes/MobileFrontend.body.php
index 6894d9d..0dbaa18 100644
--- a/includes/MobileFrontend.body.php
+++ b/includes/MobileFrontend.body.php
@@ -143,7 +143,6 @@
                $ns = $this->getTitle()->getNamespace();
                $isMainPage = $this->getTitle()->isMainPage();
                $isFilePage = $ns === NS_FILE;
-               $formatter->enableRemovableSections( 
$context->isBetaGroupMember() && $ns === NS_MAIN && !$isMainPage );
                $doc = $formatter->getDoc();
                wfProfileOut( __METHOD__ . '-formatter-init' );
 
diff --git a/javascripts/modules/mf-toggle-dynamic.js 
b/javascripts/modules/mf-toggle-dynamic.js
index 6809b4b..6dc6f56 100644
--- a/javascripts/modules/mf-toggle-dynamic.js
+++ b/javascripts/modules/mf-toggle-dynamic.js
@@ -1,10 +1,9 @@
 ( function( M, $ ) {
 
-var T = ( function() {
+( function() {
        var
                toggle = M.require( 'toggle' ),
-               currentPage,
-               Page = M.require( 'page' );
+               currentPage;
 
        M.on( 'section-toggle', function( section_id ) {
                var
@@ -35,8 +34,9 @@
                }
        }
 
-       function refresh() {
-               var references = currentPage.getReferenceSection();
+       function refresh( page ) {
+               var references = page.getReferenceSection();
+               currentPage = page;
                if ( references ) {
                        $( '#content_' + references.index ).html( 
references.content ).data( 'loaded', true );
                        M.emit( 'references-loaded' );
@@ -44,27 +44,8 @@
                checkHash();
        }
 
-       function init() {
-               var pageTitle = mw.config.get( 'wgTitle'),
-                       inViewMode = mw.config.get( 'wgAction' ) === 'view',
-                       isMainPage = mw.config.get( 'wgIsMainPage' ),
-                       isMainNamespace = mw.config.get( 'wgNamespaceNumber' ) 
===  mw.config.get( 'wgNamespaceIds' )[''];
-
-               if ( !isMainPage && isMainNamespace && inViewMode ) {
-                       M.history.retrievePage( pageTitle ).done( function( 
pageData ) {
-                               currentPage = new Page( pageData );
-                               refresh();
-                       } );
-               }
-       }
        M.on( 'page-loaded', refresh );
 
-       return {
-               init: init
-       };
-
 }() );
-
-M.define( 'toggle-dynamic', T );
 
 }( mw.mobileFrontend, jQuery ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/65134
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I40ebba95146fbb97db550933bc891ff47aa23324
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits