Clancer has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65139
Change subject: (bug 34496) Added line to watchlist tooltip displaying the
difference in characters more/less. This makes the user interface more user
friendly not everyone knows that a character is one byte.
......................................................................
(bug 34496) Added line to watchlist tooltip displaying the difference
in characters more/less. This makes the user interface more user friendly
not everyone knows that a character is one byte.
Change-Id: I9649b0edf33519b0f934ec1635438d14b4614a8d
---
M includes/ChangesList.php
M languages/messages/MessagesEn.php
2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/39/65139/1
diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index 1b6b396..236fe76 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -246,10 +246,17 @@
$formattedSizeClass = 'mw-plusminus-neg';
}
+ if ( $szdiff > 0 ) {
+ $formattedCharacterChange = $context->msg(
'rc-characters-more' )->numParams( $szdiff )->text();
+ } else {
+
+ $formattedCharacterChange = $context->msg(
'rc-characters-less' )->numParams( -$szdiff )->text();
+ }
+
$formattedTotalSize = $context->msg( 'rc-change-size-new'
)->numParams( $new )->text();
return Html::element( $tag,
- array( 'dir' => 'ltr', 'class' => $formattedSizeClass,
'title' => $formattedTotalSize ),
+ array( 'dir' => 'ltr', 'class' => $formattedSizeClass,
'title' => $formattedTotalSize . "\n" . $formattedCharacterChange),
$context->msg( 'parentheses', $formattedSize )->plain()
) . $lang->getDirMark();
}
diff --git a/languages/messages/MessagesEn.php
b/languages/messages/MessagesEn.php
index bc3a381..52c0475 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -2187,6 +2187,8 @@
'rc_categories_any' => 'Any',
'rc-change-size' => '$1', # only translate this message to
other languages if you have to change it
'rc-change-size-new' => '$1 {{PLURAL:$1|byte|bytes}} after
change',
+'rc-characters-more' => '$1 {{PLURAL:$1|character|characters}}
more',
+'rc-characters-less' => '$1 {{PLURAL:$1|character|characters}}
less',
'newsectionsummary' => '/* $1 */ new section',
'rc-enhanced-expand' => 'Show details (requires JavaScript)',
'rc-enhanced-hide' => 'Hide details',
--
To view, visit https://gerrit.wikimedia.org/r/65139
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9649b0edf33519b0f934ec1635438d14b4614a8d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Clancer <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
