Foxtrott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65143
Change subject: bugfix (TypeError: setting a property that has only a getter)
......................................................................
bugfix (TypeError: setting a property that has only a getter)
Change-Id: I06adc26aba1580aba4066b0a0c41f17d8342fd80
---
M .gitreview
M libs/SF_preview.js
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticForms
refs/changes/43/65143/1
diff --git a/.gitreview b/.gitreview
index 1886c3f..b719cd5 100644
--- a/.gitreview
+++ b/.gitreview
@@ -3,4 +3,5 @@
port=29418
project=mediawiki/extensions/SemanticForms
defaultbranch=master
-defaultrebase=0
\ No newline at end of file
+defaultrebase=0
+defaultremote=origin
diff --git a/libs/SF_preview.js b/libs/SF_preview.js
index 1b9bef4..0dc018d 100644
--- a/libs/SF_preview.js
+++ b/libs/SF_preview.js
@@ -195,7 +195,7 @@
for ( i = 0; i < oldBtnElement.attributes.length; i = i + 1 ) {
var attribute = oldBtnElement.attributes[i];
if ( attribute.name !== 'type' ) {
- newBtnElement[attribute.name] = attribute.value;
+ btn.attr( attribute.name, attribute.value );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/65143
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I06adc26aba1580aba4066b0a0c41f17d8342fd80
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticForms
Gerrit-Branch: master
Gerrit-Owner: Foxtrott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
