jenkins-bot has submitted this change and it was merged.
Change subject: Fix value for DOM_VK_DELETE
......................................................................
Fix value for DOM_VK_DELETE
The spec you link to appears to not correlate to the real world.
Firefox has a value of 0x2E (46 in decimal) store for this, and
both FF & Chrome report that value in my tests.
Change-Id: I4b0d4d27448587ca7381c640d6d3949402305656
---
M modules/ve/ve.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Inez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ve.js b/modules/ve/ve.js
index 57cfc5d..2eaa7f8 100644
--- a/modules/ve/ve.js
+++ b/modules/ve/ve.js
@@ -1168,7 +1168,7 @@
'DOM_VK_META': 0x9D,
'DOM_VK_BACK_SPACE': 0x08,
'DOM_VK_CAPS_LOCK': 0x14,
- 'DOM_VK_DELETE': 0x7F,
+ 'DOM_VK_DELETE': 0x2E,
'DOM_VK_END': 0x23,
'DOM_VK_ENTER': 0x0D,
'DOM_VK_ESCAPE': 0x1B,
--
To view, visit https://gerrit.wikimedia.org/r/65132
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4b0d4d27448587ca7381c640d6d3949402305656
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Inez <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
