Hashar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65239
Change subject: phplint builder now uses git-changed-in-head
......................................................................
phplint builder now uses git-changed-in-head
The phplint macro relied on the old ant build script. Its main feature
was merely to find modified php/php5/inc/phtml files in HEAD.
The git-changed-in-head is way nicer to find those changes.
Change-Id: I1eddacb044e4c614c3051bafe5797a3b96085f49
---
M macro.yaml
1 file changed, 3 insertions(+), 12 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/integration/jenkins-job-builder-config
refs/changes/39/65239/1
diff --git a/macro.yaml b/macro.yaml
index 2b0a89f..e862f6f 100644
--- a/macro.yaml
+++ b/macro.yaml
@@ -282,18 +282,9 @@
- builder:
name: phplint
builders:
- # For some reason php5-parsekit segfaults when an error is encountered
- # - shell: |
- # #!/bin/bash
- # # Files changed in this revision, excluding deleted files and
non-php files.
- # # -z disables the shell escape git does by default with --name-only
separates with null-byte instead of new line.
- # files=$(git diff HEAD^..HEAD --name-only -z --no-renames
--diff-filter=ACM | tr '\0' '\n' | grep -E '\.(php|php5|inc|phtml)$')
- # # Use null-byte as list separator
- # IFS=$'\n'
- # php -dextension=parsekit.so /var/lib/jenkins/bin/lint.php -v $files
- - ant:
- targets: 'php-lint'
- buildfile: '/var/lib/jenkins/jobs/_shared/build.xml'
+ - shell: |
+ /var/lib/jenkins/bin/git-changed-in-head php php5 inc phtml \
+ | xargs -n1 -t php -l
# run phpcs on any .php and .inc files in the workspace
# Except for Messages* and *.i18n.php (such as in installer)
--
To view, visit https://gerrit.wikimedia.org/r/65239
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1eddacb044e4c614c3051bafe5797a3b96085f49
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
