[MediaWiki-commits] [Gerrit] GeoCrumbs: add schema.org/data-vocabulary.org metadata - change (mediawiki...GeoCrumbs)

[Ruud Koot (Code Review)]

Ruud Koot has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65285


Change subject: GeoCrumbs: add schema.org/data-vocabulary.org metadata
......................................................................

GeoCrumbs: add schema.org/data-vocabulary.org metadata

Google uses this metadata to also display breadcrumbs in its
seach results.

Change-Id: I54df148e8a8d025f744be7426291835c4ef1a31b
---
M GeoCrumbs.class.php
M GeoCrumbs.i18n.php
2 files changed, 10 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GeoCrumbs 
refs/changes/85/65285/1

diff --git a/GeoCrumbs.class.php b/GeoCrumbs.class.php
index f1b134b..a01116a 100644
--- a/GeoCrumbs.class.php
+++ b/GeoCrumbs.class.php
@@ -93,16 +93,12 @@
                        return true;
                }
 
-               $breadcrumbs = $this->makeTrail( $skinTpl->getTitle() );
+               $breadcrumbs = implode( $this->makeTrail( $skinTpl->getTitle() 
) );
 
-               if ( count( $breadcrumbs ) > 1 ) {
-                       $breadcrumbs = implode( wfMessage( 
'geocrumbs-delimiter' )->inContentLanguage()->text(), $breadcrumbs );
+               $oldsubtitle = $QuickTmpl->data['subtitle'];
+               $subtitle = $oldsubtitle ? "$breadcrumbs<br />\n$oldsubtitle" : 
$breadcrumbs;
 
-                       $oldsubtitle = $QuickTmpl->data['subtitle'];
-                       $subtitle = $oldsubtitle ? "$breadcrumbs<br 
/>\n$oldsubtitle" : $breadcrumbs;
-
-                       $QuickTmpl->set( 'subtitle', $subtitle );
-               }
+               $QuickTmpl->set( 'subtitle', $subtitle );
 
                return true;
        }
@@ -120,7 +116,10 @@
                        if ( $cnt == 0 ) {
                                $link = $title->getSubpageText();
                        } else {
-                               $link = Linker::link( $title, 
$title->getSubpageText() );
+                               $link = '<span itemscope 
itemtype="http://data-vocabulary.org/Breadcrumb";>'
+                                     . Linker::link( $title, '<span 
itemprop="title">' . $title->getSubpageText() . '</span>' )
+                                     . wfMessage( 'geocrumbs-delimiter' 
)->inContentLanguage()->text()
+                                     . '</span>';
                        }
 
                        // mark redirects with italics.
diff --git a/GeoCrumbs.i18n.php b/GeoCrumbs.i18n.php
index c8185d4..1c6ee61 100644
--- a/GeoCrumbs.i18n.php
+++ b/GeoCrumbs.i18n.php
@@ -9,7 +9,7 @@
 $messages = array();
 
 $messages['en'] = array(
-       'geocrumbs-delimiter' => '&#32;>&#32;',
+       'geocrumbs-delimiter' => '&#32;&gt;&#32;',
        'geocrumbs-desc' => 'Adds a trail of bread crumbs to the page',
 );
 
@@ -96,7 +96,7 @@
  * @author David1010
  */
 $messages['ka'] = array(
-       'geocrumbs-delimiter' => '&#32;>&#32;',
+       'geocrumbs-delimiter' => '&#32;&gt;&#32;',
 );
 
 /** Korean (한국어)

-- 
To view, visit https://gerrit.wikimedia.org/r/65285
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54df148e8a8d025f744be7426291835c4ef1a31b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GeoCrumbs
Gerrit-Branch: master
Gerrit-Owner: Ruud Koot <in...@ruudkoot.nl>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits