jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused toolbar group name.
......................................................................
Remove unused toolbar group name.
Can't see why we'd need to style toolbar groups differently.
Change-Id: I0646b8cf37ab19e34a8ed2eb8558773365403610
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
M modules/ve/init/ve.init.Target.js
M modules/ve/ui/ve.ui.Toolbar.js
3 files changed, 9 insertions(+), 10 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index c241252..628d1a3 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -153,10 +153,10 @@
};
ve.init.mw.ViewPageTarget.static.toolbarTools = [
- { 'name': 'history', 'items' : ['undo', 'redo'] },
- { 'name': 'textStyle', 'items' : ['mwFormat'] },
- { 'name': 'textStyle', 'items' : ['bold', 'italic', 'mwLink',
'clear'] },
- { 'name': 'list', 'items' : ['number', 'bullet', 'outdent',
'indent'] }
+ { 'items': ['undo', 'redo'] },
+ { 'items': ['mwFormat'] },
+ { 'items': ['bold', 'italic', 'mwLink', 'clear'] },
+ { 'items': ['number', 'bullet', 'outdent', 'indent'] }
];
ve.init.mw.ViewPageTarget.static.surfaceCommands = [
diff --git a/modules/ve/init/ve.init.Target.js
b/modules/ve/init/ve.init.Target.js
index cb96eb9..166dab0 100644
--- a/modules/ve/init/ve.init.Target.js
+++ b/modules/ve/init/ve.init.Target.js
@@ -30,10 +30,10 @@
/* Static Properties */
ve.init.Target.static.toolbarTools = [
- { 'name': 'history', 'items' : ['undo', 'redo'] },
- { 'name': 'textStyle', 'items' : ['format'] },
- { 'name': 'textStyle', 'items' : ['bold', 'italic', 'link', 'clear'] },
- { 'name': 'list', 'items' : ['number', 'bullet', 'outdent', 'indent'] }
+ { 'items': ['undo', 'redo'] },
+ { 'items': ['format'] },
+ { 'items': ['bold', 'italic', 'link', 'clear'] },
+ { 'items': ['number', 'bullet', 'outdent', 'indent'] }
];
ve.init.Target.static.surfaceCommands = [
diff --git a/modules/ve/ui/ve.ui.Toolbar.js b/modules/ve/ui/ve.ui.Toolbar.js
index f4b802e..c5ea951 100644
--- a/modules/ve/ui/ve.ui.Toolbar.js
+++ b/modules/ve/ui/ve.ui.Toolbar.js
@@ -165,8 +165,7 @@
group = tools[i];
// Create group
$group = this.$$( '<div class="ve-ui-toolbar-group"></div>' )
- .on( 'mousedown', false )
- .addClass( 've-ui-toolbar-group-' + group.name );
+ .on( 'mousedown', false );
if ( group.label ) {
$group.append(
this.$$( '<div
class="ve-ui-toolbar-label"></div>' ).html( group.label )
--
To view, visit https://gerrit.wikimedia.org/r/65298
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0646b8cf37ab19e34a8ed2eb8558773365403610
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
