Jarry1250 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65339


Change subject: Reimplement beforeSubmit, afterSubmit and afterRegisterFeatures 
hooks
......................................................................

Reimplement beforeSubmit, afterSubmit and afterRegisterFeatures hooks

All three were present in pre- but not post-TUX JavaScript. Here, they
are recreated in a backwards-friendly way.

Change-Id: Ieae2148dfe2cd1b2e3005683c6e4b1eec3afb263
---
M resources/js/ext.translate.editor.helpers.js
M resources/js/ext.translate.editor.js
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/39/65339/1

diff --git a/resources/js/ext.translate.editor.helpers.js 
b/resources/js/ext.translate.editor.helpers.js
index d7d0a5f..98a42f7 100644
--- a/resources/js/ext.translate.editor.helpers.js
+++ b/resources/js/ext.translate.editor.helpers.js
@@ -444,6 +444,7 @@
                                translateEditor.showSupportOptions( 
result.helpers.support );
                                translateEditor.addDefinitionDiff( 
result.helpers.definitiondiff );
                                mw.translateHooks.run( 
'showTranslationHelpers', result.helpers, translateEditor.$editor );
+                               mw.translateHooks.run( 'afterRegisterFeatures', 
translateEditor.$editor );
 
                        } ).fail( function ( errorCode, results ) {
                                mw.log( 'Error loading translation aids ' + 
errorCode + results.error.info );
diff --git a/resources/js/ext.translate.editor.js 
b/resources/js/ext.translate.editor.js
index ed130fe..110b780 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -115,9 +115,10 @@
                 */
                save: function () {
                        var translateEditor = this,
-                               api = new mw.Api(),
-                               translation = translateEditor.$editor.find( 
'.editcolumn textarea' ).val();
+                               api = new mw.Api();
 
+                       mw.translateHooks.run( 'beforeSubmit', 
translateEditor.$editor );
+                       var translation = translateEditor.$editor.find( 
'.editcolumn textarea' ).val();
                        translateEditor.saving = true;
 
                        // beforeSave callback
@@ -162,6 +163,7 @@
                                }
 
                                mw.translate.dirty = false;
+                               mw.translateHooks.run( 'afterSubmit', 
translateEditor.$editor );
                        } ).fail( function ( errorCode, results ) {
                                translateEditor.savingError( results.error.info 
);
 

-- 
To view, visit https://gerrit.wikimedia.org/r/65339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieae2148dfe2cd1b2e3005683c6e4b1eec3afb263
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Jarry1250 <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to