Mwjames has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65352


Change subject: Improve smw constructor
......................................................................

Improve smw constructor

Change-Id: I4f862761e3a649fdcb9c44358aa09b37d8585f7b
---
M resources/smw/ext.smw.css
M resources/smw/ext.smw.js
2 files changed, 17 insertions(+), 65 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/52/65352/1

diff --git a/resources/smw/ext.smw.css b/resources/smw/ext.smw.css
index 02d99d8..02a0c2e 100644
--- a/resources/smw/ext.smw.css
+++ b/resources/smw/ext.smw.css
@@ -1,4 +1,4 @@
-/**
+/*!
  * This file is part of the Semantic MediaWiki Extension
  * @see https://semantic-mediawiki.org/
  *
@@ -20,8 +20,6 @@
  * @since 1.8
  *
  * @file
- * @ignore
- *
  * @ingroup SMW
  *
  * @licence GNU GPL v2+
@@ -29,18 +27,12 @@
  * @author mwjames
  */
 
-/**
- * highlighting for builtin elements
- * @ignore
- */
+/* highlighting for builtin elements */
 span.smwbuiltin, span.smwttactiveinline span.smwbuiltin {
        font-style: italic;
 }
 
-/**
- * make divs look like <pre>
- * @ignore
- */
+/* make divs look like <pre> */
 div.smwpre {
        white-space: pre;
        font-family: monospace;
@@ -53,34 +45,22 @@
        margin-top: 0.5em;
 }
 
-/**
- * terminate page contents when inserting stuff below a page, typically used 
in <br>
- * @ignore
- */
+/* terminate page contents when inserting stuff below a page, typically used 
in <br> */
 #smwfootbr {
        clear: both;
 }
 
-/**
- * hide keys for sorting table entries
- * @ignore
- */
+/* hide keys for sorting table entries */
 span.smwsortkey {
        display: none;
 }
 
-/**
- * buttons for sort-arrows
- * @ignore
- */
+/* buttons for sort-arrows */
 a.sortheader:hover {
        text-decoration: none;
 }
 
-/**
- * "semantic" span classes for Timeline
- * @ignore
- */
+/* "semantic" span classes for Timeline */
 div.smwtimeline {
        border: 1px solid #AAAAAA;
        background-color: #F9F9F9;
@@ -100,10 +80,7 @@
        padding: 5px;
 }
 
-/**
- * Factbox
- * @ignore
- */
+/* Factbox */
 div.smwfact {
        clear: both;
        background-color: #F9F9F9;
@@ -145,10 +122,7 @@
        color: #DDDDDD;
 }
 
-/**
- * warning messages
- * @ignore
- */
+/* warning messages */
 span.smwwarning {
        color: #888888;
        font-style: italic;
@@ -156,11 +130,7 @@
 }
 
 
-/**
- * search, browse, RDF icons
- * FIXME: this was only used for Factbox docu, should be removed from code
- * @ignore
- */
+/* Search, browse, RDF icons/ FIXME: this was only used for Factbox docu, 
should be removed from code */
 span.smwsearchicon {
        padding-right: 16px;
        margin-right: 2px;
@@ -243,11 +213,7 @@
        /* @embed */ background: url(../images/rdf_flyer.18.gif) center right 
no-repeat;
 }
 
-/**
- * @TODO Browse and Factbox should be split into seperated CSS file
- * CSS style file for Semantic MediaWiki Special Browse.
- * @ignore
- */
+/* @TODO Browse and Factbox should be split into seperated CSS file, CSS style 
file for Semantic MediaWiki Special Browse. */
 table.smwb-factbox {
        border-left: 8px solid #DDDDDD;
        width: 100%
@@ -343,21 +309,14 @@
 span.smwb-ivalue {
 }
 
-/**
- * @since 1.9
- * @ignore
- */
+/* @since 1.9; Spinner */
 .smw-spinner .text {
        padding-left: 2.1em;
        font-size: 12px;
        vertical-align: middle;
 }
 
-/**
- * Spinner for left side in-text
- * @since 1.9
- * @ignore
- */
+/* @since 1.9; Spinner for left side in-text */
 .smw-spinner.left.mw-small-spinner {
        background-position:left;
        vertical-align: middle;
@@ -365,11 +324,7 @@
        padding: 0px !important;
 }
 
-/**
- * Sppiner for image center
- * @since 1.9
- * @ignore
- */
+/* @since 1.9; Sppinner for image center */
 .smw-spinner.center.mw-small-spinner {
        vertical-align: middle;
        display:inline-block;
diff --git a/resources/smw/ext.smw.js b/resources/smw/ext.smw.js
index e4b5708..4663793 100644
--- a/resources/smw/ext.smw.js
+++ b/resources/smw/ext.smw.js
@@ -32,11 +32,11 @@
 /**
  * Declares methods and properties that are available through the smw namespace
  *
- * @since  1.8
+ * @since 1.8
  * @class smw
  * @singleton
  */
-var instance = ( function ( $ ) {
+var smw = ( function ( $ ) {
        'use strict';
 
        /*global console:true message:true */
@@ -349,7 +349,4 @@
 } )( jQuery );
 
 // Assign namespace
-window.smw = window.semanticMediaWiki = instance;
-
-( function( $ ) { 'use strict'; $( document ).ready( function() {
-} ); } )( jQuery );
\ No newline at end of file
+window.smw = window.semanticMediaWiki = smw;
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/65352
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f862761e3a649fdcb9c44358aa09b37d8585f7b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Mwjames <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to