Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65369
Change subject: Fix spelling of JavaScript
......................................................................
Fix spelling of JavaScript
Change-Id: Ie487e3408802f76e383eec1a8e9b841cd86e0ecf
---
M MobileFrontend.i18n.php
M README.mediawiki
M includes/skins/SkinMinerva.php
M less/common/mf-navigation.less
M less/modules/talk.less
5 files changed, 13 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/69/65369/1
diff --git a/MobileFrontend.i18n.php b/MobileFrontend.i18n.php
index 591fd25..cc20992 100644
--- a/MobileFrontend.i18n.php
+++ b/MobileFrontend.i18n.php
@@ -125,7 +125,7 @@
'mobile-frontend-nearby-title' => 'Nearby',
'mobile-frontend-nearby-loading' => 'Loading topics near your current
location',
'mobile-frontend-nearby-requirements' => 'Sorry! Your web browser
doesn\'t support {{SITENAME}} Nearby.',
- 'mobile-frontend-nearby-requirements-guidance' => 'Try a different
browser or enable javascript if you\'ve disabled it.',
+ 'mobile-frontend-nearby-requirements-guidance' => 'Try a different
browser or enable JavaScript if you\'ve disabled it.',
'mobile-frontend-nearby-distance' => '{{PLURAL:$1|$1 km}}',
'mobile-frontend-nearby-distance-meters' => '{{PLURAL:$1|$1 m}}',
'mobile-frontend-nearby-lookup-ui-error' => '{{SITENAME}} Nearby can\'t
figure out where you are… try again?',
@@ -478,7 +478,7 @@
'mobile-frontend-main-menu-discovery' => 'Discovery menu header in main
menu',
'mobile-frontend-main-menu-personal' => 'Menu header in main menu for
pages personalised for a user',
'mobile-frontend-main-menu-settings-heading' =>
'{{doc-special|MobileOptions|unlisted=1}}',
- 'mobile-frontend-settings-site-header' => 'Heading for the
Special:MobileOptions/Language page - only visible to non javascript users',
+ 'mobile-frontend-settings-site-header' => 'Heading for the
Special:MobileOptions/Language page - only visible to non JavaScript users',
'mobile-frontend-settings-site-description' => 'Shown on
Special:MobileOptions
*$1 - the number of other language versions for this wiki',
'mobile-frontend-main-menu-account-create' => 'Account creation link in
main menu.
@@ -492,13 +492,13 @@
{{Identical|History}}',
'mobile-frontend-meta-data-issues-header' => 'Heading for overlay
listing all cleanup templates',
'mobile-frontend-meta-data-issues' => 'This should be several words and
should explain that an article has cleanup templates on it - meaning there is
room for improvement on the page. It appears in a button that when clicked
opens the overlay with heading
{{msg-mw|mobile-frontend-meta-data-issues-header}}',
- 'mobile-frontend-ajax-preview-loading' => 'Text that accompanies an
ajax loader when you dynamically load an article preview overlay via
javascript',
+ 'mobile-frontend-ajax-preview-loading' => 'Text that accompanies an
ajax loader when you dynamically load an article preview overlay via
JavaScript',
'mobile-frontend-page-saving' => 'Text shown whilst an article is being
saved.
{{Identical|Saving}}',
'mobile-frontend-nearby-title' => 'Title of Special:Nearby.
{{Identical|Nearby}}',
'mobile-frontend-nearby-loading' => 'Informative message telling user
that their location is being looked up',
- 'mobile-frontend-nearby-requirements' => 'Message shown to users who
have no javascript or a browser that is not capable',
+ 'mobile-frontend-nearby-requirements' => 'Message shown to users who
have no JavaScript or a browser that is not capable',
'mobile-frontend-nearby-requirements-guidance' => 'Message explaining
actions user can take when keying error
{{msg-mw|mobile-frontend-nearby-requirements}}',
'mobile-frontend-nearby-distance' => 'States distance to current
location in kilometers',
'mobile-frontend-nearby-distance-meters' => 'States distance to current
location in meters for numbers less than 1km',
@@ -534,7 +534,7 @@
'mobile-frontend-watchlist-view' => 'Link to your watchlist',
'mobile-frontend-watchlist-more' => 'Label for link that shows more
pages of the watchlist a-z view.
{{Identical|More}}',
- 'mobile-frontend-watchlist-cta' => 'Appears above the login form when
you click watchlist icon when not logged in. First link is to login form, 2nd
to sign up form. Links are created in javascript.',
+ 'mobile-frontend-watchlist-cta' => 'Appears above the login form when
you click watchlist icon when not logged in. First link is to login form, 2nd
to sign up form. Links are created in JavaScript.',
'mobile-frontend-watchlist-cta-button-login' => 'A link with label to
login page
{{Identical|Login}}',
'mobile-frontend-watchlist-cta-button-signup' => 'A link with label to
sign up page
@@ -10694,7 +10694,7 @@
'mobile-frontend-page-saving' => 'Se salvează $1',
'mobile-frontend-nearby-title' => 'În apropiere',
'mobile-frontend-nearby-loading' => 'Se încarcă subiecte din apropierea
dumneavoastră',
- 'mobile-frontend-nearby-requirements' => 'Această pagină necesită atât
javascript, cât și un navigator capabil de a furniza locația.',
+ 'mobile-frontend-nearby-requirements' => 'Această pagină necesită atât
JavaScript, cât și un navigator capabil de a furniza locația.',
'mobile-frontend-nearby-distance' => '{{PLURAL:$1|$1 km}}',
'mobile-frontend-nearby-distance-meters' => '{{PLURAL:$1|$1 m}}',
'mobile-frontend-nearby-lookup-error' => 'Nu v-am putut repera.
Reîncercați...',
diff --git a/README.mediawiki b/README.mediawiki
index 170ce53..082a994 100644
--- a/README.mediawiki
+++ b/README.mediawiki
@@ -27,7 +27,7 @@
export PATH=/Users/{username}/.npm/less/1.3.0/package/bin/.
Ensure all css passes the
[https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS style guidelines]
-When adding a javascript module, ensure that the css module has the same name.
+When adding a JavaScript module, ensure that the css module has the same name.
e.g. javascripts/modules/mf-toggle.js has the corresponding less/css
stylesheets stylesheets/less/modules/mf-toggle.less and
stylesheets/modules/mf-toggle.css
Introduce any browser specific patches in the relevant stylesheet. If the
browser does not have its own stylesheet considering adding one in
DeviceDetection.php
@@ -35,7 +35,7 @@
NEVER use [http://www.w3.org/TR/CSS2/selector.html#attribute-selectors
attribute selectors] - these are known to cause issues in the
[https://github.com/wikimedia/WikipediaMobile phonegap app] which shares some
of this codebase.
=== Javascript ===
-Javascript can be found in the javascript folder. Any javascript committed to
the core must pass the
[https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript style
guidelines]
+Javascript can be found in the javascript folder. Any JavaScript committed to
the core must pass the
[https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript style
guidelines]
==== JSHint ====
Install JSHint
@@ -44,7 +44,7 @@
</code>
==== Pre-commit hook ====
-A pre-commit hook is provided in the scripts directory to assist with adhering
to javascript code standards as well as running code through jshint. Install
like so:
+A pre-commit hook is provided in the scripts directory to assist with adhering
to JavaScript code standards as well as running code through jshint. Install
like so:
<code>
ln -s $PWD/scripts/pre-commit .git/hooks/pre-commit
chmod +x scripts/pre-commit
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index cc720d5..c9dff97 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -85,7 +85,8 @@
}
/**
- * Returns array of config variables that should be added only to this
skin for use in javascript
+ * Returns array of config variables that should be added only to this
skin
+ * for use in JavaScript.
* @return Array
*/
public function getSkinConfigVariables() {
diff --git a/less/common/mf-navigation.less b/less/common/mf-navigation.less
index 61bd4c6..b1eb03c 100644
--- a/less/common/mf-navigation.less
+++ b/less/common/mf-navigation.less
@@ -26,7 +26,7 @@
}
li.watch-this-article,
-a.watch-this-article { // FIXME: Make the page watch star appear to
non-javascript users so this css rule is used on non-js devices
+a.watch-this-article { // FIXME: Make the page watch star appear to
non-JavaScript users so this css rule is used on non-js devices
background-image: url(images/watch.png);
background-position: center center;
.background-size( auto, @watchThisArticleSize );
diff --git a/less/modules/talk.less b/less/modules/talk.less
index c7448e7..36ce3a5 100644
--- a/less/modules/talk.less
+++ b/less/modules/talk.less
@@ -4,7 +4,7 @@
@speechBubbleColor: #C91F2C;
.alpha {
- // FIXME: probably want to use consistent styling for non-javascript
users. Move into common.css?
+ // FIXME: probably want to use consistent styling for non-JavaScript
users. Move into common.css?
#talk {
right: @contentMarginRight;
z-index: 5;
--
To view, visit https://gerrit.wikimedia.org/r/65369
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie487e3408802f76e383eec1a8e9b841cd86e0ecf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
