Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65399


Change subject: SkinTemplateTabs was remove in 1.18
......................................................................

SkinTemplateTabs was remove in 1.18

Removing the protection action hiding, not worth it

Change-Id: I6504304c9dc2d3553ea1460226877a0b78a22f5e
---
M Translate.php
M TranslateEditAddons.php
2 files changed, 1 insertion(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/99/65399/1

diff --git a/Translate.php b/Translate.php
index fe63d5c..142abf8 100644
--- a/Translate.php
+++ b/Translate.php
@@ -121,13 +121,10 @@
 $wgHooks['ApiTokensGetTokenTypes'][] = 
'ApiTranslateSandbox::injectTokenFunction';
 // Register hooks.
 $wgHooks['EditPage::showEditForm:initial'][] = 'TranslateEditAddons::addTools';
-$wgHooks['SkinTemplateTabs'][] = 'TranslateEditAddons::addNavigationTabs';
-// Same for Vector skin
 $wgHooks['SkinTemplateNavigation'][] = 
'TranslateEditAddons::addNavigationTabs';
 $wgHooks['AlternateEdit'][] = 'TranslateEditAddons::intro';
 $wgHooks['EditPageBeforeEditButtons'][] = 'TranslateEditAddons::buttonHack';
 $wgHooks['EditPage::showEditForm:fields'][] = 
'TranslateEditAddons::keepFields';
-$wgHooks['SkinTemplateTabs'][] = 'TranslateEditAddons::tabs';
 $wgHooks['LanguageGetTranslatedLanguageNames'][] = 
'TranslateHooks::translateMessageDocumentationLanguage';
 $wgHooks['TranslateSupportedLanguages'][] = 
'TranslateHooks::translateMessageDocumentationLanguage';
 $wgHooks['ArticlePrepareTextForEdit'][] = 
'TranslateEditAddons::disablePreSaveTransform';
diff --git a/TranslateEditAddons.php b/TranslateEditAddons.php
index 37afc96..bd96d92 100644
--- a/TranslateEditAddons.php
+++ b/TranslateEditAddons.php
@@ -18,7 +18,7 @@
 class TranslateEditAddons {
        /**
         * Add some tabs for navigation for users who do not use Ajax interface.
-        * Hooks: SkinTemplateNavigation, SkinTemplateTabs
+        * Hooks: SkinTemplateNavigation
         */
        static function addNavigationTabs( Skin $skin, array &$tabs ) {
                $title = $skin->getTitle();
@@ -288,19 +288,6 @@
                # wfDeprecated( __METHOD__, '1.19' );
                $handle = new MessageHandle( $title );
                return $handle->isFuzzy();
-       }
-
-       /**
-        * Removes protection tab for message namespaces - not useful.
-        * Hook: SkinTemplateTabs
-        */
-       public static function tabs( Skin $skin, &$tabs ) {
-               $handle = new MessageHandle( $skin->getTitle() );
-               if ( $handle->isMessageNamespace() ) {
-                       unset( $tabs['protect'] );
-               }
-
-               return true;
        }
 
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/65399
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6504304c9dc2d3553ea1460226877a0b78a22f5e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to