Waldir has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65440
Change subject: Remove the id "anonlogin"
......................................................................
Remove the id "anonlogin"
This was used as an alternative id for the login link
in the personal tools at the top right.
This seems to have been inherited since the days of the PHPTal-based skins
(at least git blame shows their presence back in Brion's rewrite of the skin
in november 2004).
I've asked several people about this (Brion, Tyler, Roan, Timo, Bartosz)
And nobody could figure out why it is needed.
After all, whenever the user sees the login link it means they are
using the wiki as an anonymous user.
My best guess is that this is meant to allow the ability
to style the login differently when the user has already made an edit
anonymously (which is, if I'm not mistaken, when the anon userlinks are shown,
i.e. the links to the IP userpage and talkpage are visible),
but I see no evidence of this, and in any case it would be better to change
the class of the whole personal tools div instead of changing the link IDs.
Change-Id: Ib3445934853db5361c3c6fecfe75623b0b921400
---
M includes/SkinTemplate.php
M languages/messages/MessagesEn.php
M languages/messages/MessagesQqq.php
M maintenance/dictionary/mediawiki.dic
M maintenance/language/messageTypes.inc
M maintenance/language/messages.inc
M skins/CologneBlue.php
7 files changed, 5 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/40/65440/1
diff --git a/includes/SkinTemplate.php b/includes/SkinTemplate.php
index e3a6ccf..fd4abeb 100644
--- a/includes/SkinTemplate.php
+++ b/includes/SkinTemplate.php
@@ -659,10 +659,8 @@
: 'login';
$is_signup = $request->getText( 'type' ) == 'signup';
- # anonlogin & login are the same
$proto = $wgSecureLogin ? PROTO_HTTPS : null;
- $login_id = $this->showIPinHeader() ? 'anonlogin' :
'login';
$login_url = array(
'text' => $this->msg( $loginlink )->text(),
'href' => self::makeSpecialUrl( 'Userlogin',
$returnto, $proto ),
@@ -698,7 +696,7 @@
$personal_urls['createaccount'] =
$createaccount_url;
}
- $personal_urls[$login_id] = $login_url;
+ $personal_urls['login'] = $login_url;
}
wfRunHooks( 'PersonalUrls', array( &$personal_urls, &$title ) );
diff --git a/languages/messages/MessagesEn.php
b/languages/messages/MessagesEn.php
index bc3a381..81a3855 100644
--- a/languages/messages/MessagesEn.php
+++ b/languages/messages/MessagesEn.php
@@ -3623,7 +3623,6 @@
'accesskey-pt-watchlist' => 'l', # do not translate or
duplicate this message to other languages
'accesskey-pt-mycontris' => 'y', # do not translate or
duplicate this message to other languages
'accesskey-pt-login' => 'o', # do not translate or
duplicate this message to other languages
-'accesskey-pt-anonlogin' => 'o', # do not translate or
duplicate this message to other languages
'accesskey-pt-logout' => '', # do not translate or duplicate
this message to other languages
'accesskey-ca-talk' => 't', # do not translate or
duplicate this message to other languages
'accesskey-ca-edit' => 'e', # do not translate or
duplicate this message to other languages
@@ -3693,7 +3692,6 @@
'tooltip-pt-watchlist' => 'A list of pages you are monitoring
for changes',
'tooltip-pt-mycontris' => 'A list of your contributions',
'tooltip-pt-login' => 'You are encouraged to log in;
however, it is not mandatory',
-'tooltip-pt-anonlogin' => 'You are encouraged to log in;
however, it is not mandatory',
'tooltip-pt-logout' => 'Log out',
'tooltip-ca-talk' => 'Discussion about the content page',
'tooltip-ca-edit' => 'You can edit this page. Please use
the preview button before saving',
diff --git a/languages/messages/MessagesQqq.php
b/languages/messages/MessagesQqq.php
index 9d5bacb..542d075 100644
--- a/languages/messages/MessagesQqq.php
+++ b/languages/messages/MessagesQqq.php
@@ -1102,8 +1102,8 @@
See also:
* {{msg-mw|Login}}
-* {{msg-mw|Accesskey-pt-anonlogin}}
-* {{msg-mw|Tooltip-pt-anonlogin}}
+* {{msg-mw|Accesskey-pt-login}}
+* {{msg-mw|Tooltip-pt-login}}
{{Identical|Log in}}",
'nav-login-createaccount' => "Shown to anonymous users in the upper right
corner of the page. When you can't create an account, the message
{{msg-mw|login}} is shown.
{{Identical|Log in / create account}}",
@@ -6378,12 +6378,6 @@
* {{msg-mw|Accesskey-pt-mycontris}}
* {{msg-mw|Tooltip-pt-mycontris}}',
'tooltip-pt-login' => "Tooltip shown when hovering over the link 'Log in /
create account' in the upper right corner show on all pages while not logged
in.",
-'tooltip-pt-anonlogin' => 'Used as tooltip for link {{msg-mw|Login}} in your
personal toolbox (upper right side).
-
-See also:
-* {{msg-mw|Login}}
-* {{msg-mw|Accesskey-pt-anonlogin}}
-* {{msg-mw|Tooltip-pt-anonlogin}}',
'tooltip-pt-logout' => 'Tooltip shown when hovering over the {{msg-mw|Logout}}
link in your personal toolbox (upper right side).
See also:
diff --git a/maintenance/dictionary/mediawiki.dic
b/maintenance/dictionary/mediawiki.dic
index 59ea18f..0f38827 100644
--- a/maintenance/dictionary/mediawiki.dic
+++ b/maintenance/dictionary/mediawiki.dic
@@ -480,7 +480,6 @@
andtitle
anon
anoneditwarning
-anonlogin
anonnotice
anononly
anonpreviewwarning
diff --git a/maintenance/language/messageTypes.inc
b/maintenance/language/messageTypes.inc
index 17feaf9..5a3dea9 100644
--- a/maintenance/language/messageTypes.inc
+++ b/maintenance/language/messageTypes.inc
@@ -32,7 +32,6 @@
'accesskey-pt-watchlist',
'accesskey-pt-mycontris',
'accesskey-pt-login',
- 'accesskey-pt-anonlogin',
'accesskey-pt-logout',
'accesskey-ca-talk',
'accesskey-ca-edit',
diff --git a/maintenance/language/messages.inc
b/maintenance/language/messages.inc
index fdd37e6..b9fa854 100644
--- a/maintenance/language/messages.inc
+++ b/maintenance/language/messages.inc
@@ -2546,7 +2546,6 @@
'accesskey-pt-watchlist',
'accesskey-pt-mycontris',
'accesskey-pt-login',
- 'accesskey-pt-anonlogin',
'accesskey-pt-logout',
'accesskey-ca-talk',
'accesskey-ca-edit',
@@ -2617,7 +2616,6 @@
'tooltip-pt-watchlist',
'tooltip-pt-mycontris',
'tooltip-pt-login',
- 'tooltip-pt-anonlogin',
'tooltip-pt-logout',
'tooltip-ca-talk',
'tooltip-ca-edit',
diff --git a/skins/CologneBlue.php b/skins/CologneBlue.php
index d766b64..d8bb4ae 100644
--- a/skins/CologneBlue.php
+++ b/skins/CologneBlue.php
@@ -380,7 +380,7 @@
);
$personalUrls = $this->getPersonalTools();
- foreach ( array( 'logout', 'createaccount', 'login',
'anonlogin' ) as $key ) {
+ foreach ( array( 'logout', 'createaccount', 'login' ) as $key )
{
if ( $personalUrls[$key] ) {
$s[] = $this->makeListItem( $key,
$personalUrls[$key], array( 'tag' => 'span' ) );
}
@@ -421,7 +421,7 @@
// Personal tools ("My pages")
$qbmyoptions = $this->getPersonalTools();
- foreach ( array( 'logout', 'createaccount', 'login',
'anonlogin' ) as $key ) {
+ foreach ( array( 'logout', 'createaccount', 'login', ) as $key
) {
$qbmyoptions[$key] = null;
}
--
To view, visit https://gerrit.wikimedia.org/r/65440
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib3445934853db5361c3c6fecfe75623b0b921400
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Waldir <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
