jenkins-bot has submitted this change and it was merged.

Change subject: Allow VirtualBox to manage permissions of shared files
......................................................................


Allow VirtualBox to manage permissions of shared files

Specifying fmode/dmode parameters to VirtualBox makes it more difficult to use
NFS as the implementation for folder-sharing, and makes it too easy to write
Puppet code that causes an endless file permission back-and-forth between
Puppet and VirtualBox.

Change-Id: I1d4a184e627ef072126ed19d505de4c53efbe141
---
M Vagrantfile
M puppet/modules/mediawiki/manifests/extension.pp
2 files changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Ori.livneh: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Vagrantfile b/Vagrantfile
index b0a7c0b..ba72218 100644
--- a/Vagrantfile
+++ b/Vagrantfile
@@ -67,8 +67,7 @@
     config.vm.synced_folder '.', '/vagrant',
         id: 'vagrant-root',
         owner: 'vagrant',
-        group: 'www-data',
-        extra: 'dmode=775,fmode=775'
+        group: 'www-data'
 
     config.vm.provider :virtualbox do |vb|
         # See http://www.virtualbox.org/manual/ch08.html for additional 
options.
diff --git a/puppet/modules/mediawiki/manifests/extension.pp 
b/puppet/modules/mediawiki/manifests/extension.pp
index 4cb62e8..6f66613 100644
--- a/puppet/modules/mediawiki/manifests/extension.pp
+++ b/puppet/modules/mediawiki/manifests/extension.pp
@@ -96,7 +96,6 @@
                # over the file.
                owner   => 'vagrant',
                group   => 'www-data',
-               mode    => '0770',
                require => Git::Clone["mediawiki/extensions/${extension}"],
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/65448
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1d4a184e627ef072126ed19d505de4c53efbe141
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to